test: Fix consistent failure in IPv6 masquerading test #25036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This IPv6 masquerading test has been failing consistently for a while
with:
Cannot get client IPv6
The reason this happens is very simple: the pod whose IPv6 it tries to
retrieve was never deployed.
This bug was introduced in 70d3f99 ("test: Move IPv6 iptables
masquerade test to DP suite"). It wasn't noticed because the test was
already quarantined at the time.
This fix is never not expected to completely fix the test. I'm therefore
not unquarantining it yet.
Fixes: 70d3f99 ("test: Move IPv6 iptables masquerade test to DP suite")
Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
added
release-note/ci
nbusseneau
approved these changes
Apr 21, 2023
There was a problem hiding this comment.
This bug was introduced in 70d3f99 ("test: Move IPv6 iptables
masquerade test to DP suite").
See, I knew it was Martynas. Why does no one believe me?
|
None of the changes are datapath-specific so I think we can skip that review. The test is also quarantined so won't run in this PR's CI. I've tested the fix locally and we'll see in quarantined runs if it's enough to make the test stable again. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This IPv6 masquerading test has been failing consistently for a while with:
The reason this happens is very simple: the pod whose IPv6 it tries to retrieve was never deployed.
This bug was introduced in 70d3f99 ("test: Move IPv6 iptables masquerade test to DP suite"). It wasn't noticed because the test was already quarantined at the time.
This fix is never not expected to completely fix the test. I'm therefore not unquarantining it yet.
Fixes: #18655.
Updates: #23355.