Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

github/workflows: Enable DSR with WireGuard in ci-dp #25039

Merged
merged 1 commit into from Apr 28, 2023
Merged

github/workflows: Enable DSR with WireGuard in ci-dp #25039

merged 1 commit into from Apr 28, 2023

Conversation

brb
Copy link
Member

@brb brb commented Apr 21, 2023 •
edited

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 21, 2023
@brb
github/workflows: Enable DSR with WireGuard in ci-dp
a50f2fb 
#23328 got resolved.

We didn't enable for the second TODO as DSR is not supported with the
VXLAN.

Signed-off-by: Martynas Pumputis <m@lambda.lt>
@brb brb added area/CI-improvement Topic or proposal to improve the Continuous Integration workflow release-note/ci This PR makes changes to the CI. labels Apr 25, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 25, 2023
@brb brb marked this pull request as ready for review April 25, 2023 09:36
@brb brb requested review from a team as code owners April 25, 2023 09:36
gentoo-root
gentoo-root approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@gentoo-root gentoo-root left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that #23461 from test 9 was also closed recently.

@brb
Copy link
Member Author

brb commented Apr 25, 2023

Seems that #23461 from test 9 was also closed recently.

Sweet, let me try to open a separate PR.

julianwiedmann
julianwiedmann requested changes Apr 25, 2023
View reviewed changes
Copy link
Member

@julianwiedmann julianwiedmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused - the successful run wasn't successful (see config 14):
https://github.com/cilium/cilium/actions/runs/4795620155/jobs/8530423625

@brb
Copy link
Member Author

brb commented Apr 25, 2023

@julianwiedmann That run tried to change both 13 and 14, but in the final commit I ended up changing only 13, as we cannot change 14 due to:

We didn't enable for the second TODO as DSR is not supported with the VXLAN.

@brb brb requested a review from julianwiedmann April 25, 2023 11:59
@julianwiedmann
Copy link
Member

@julianwiedmann That run tried to change both 13 and 14, but in the final commit I ended up changing only 13, as we cannot change 14 due to:

We didn't enable for the second TODO as DSR is not supported with the VXLAN.

duh - thanks, that didn't parse. We could enable DSR-GENEVE of course 💯

@brb
Copy link
Member Author

brb commented Apr 25, 2023

We could enable DSR-GENEVE of course 100

My brain is lagging, but in the non-standalone LB mode, right?

@julianwiedmann
Copy link
Member

We could enable DSR-GENEVE of course 100

My brain is lagging, but in the non-standalone LB mode, right?

yep, https://docs.cilium.io/en/latest/network/kubernetes/kubeproxy-free/#direct-server-return-dsr-with-geneve

@pchaigno pchaigno changed the title WIP: github/workflows: Enable DSR with WireGuard in ci-dp github/workflows: Enable DSR with WireGuard in ci-dp Apr 25, 2023
@brb brb added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 26, 2023
@brb
Copy link
Member Author

brb commented Apr 26, 2023 •
edited

@julianwiedmann Let's do that in a separate PR. We could dedicate one configuration slot to enable GENEVE with DSR w/o encryption.

@pchaigno pchaigno merged commit 2af6925 into main Apr 28, 2023
43 checks passed
@pchaigno pchaigno deleted the pr/brb/ci-dp-wg branch April 28, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gentoo-root gentoo-root gentoo-root approved these changes

@julianwiedmann julianwiedmann julianwiedmann approved these changes

@viktor-kurchenko viktor-kurchenko viktor-kurchenko approved these changes

Assignees
No one assigned
Labels
area/CI-improvement Topic or proposal to improve the Continuous Integration workflow ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@brb @julianwiedmann @gentoo-root @viktor-kurchenko @pchaigno