Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Update k8s tests and libraries to v1.27.0" #25044

Merged
merged 2 commits into from Apr 26, 2023
Merged

Revert "Update k8s tests and libraries to v1.27.0" #25044

merged 2 commits into from Apr 26, 2023

Conversation

pchaigno
Copy link
Member

@pchaigno pchaigno commented Apr 21, 2023 •
edited

Reverts #24837.

First two commits are reverts. Last one fixes the test reporting to GitHub.

@pchaigno pchaigno added the sig/k8s Impacts the kubernetes API, or kubernetes -> cilium internals translation layers. label Apr 21, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Apr 21, 2023
@pchaigno pchaigno added the release-note/misc This PR makes changes that have no direct user impact. label Apr 21, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 21, 2023
@pchaigno pchaigno force-pushed the pr/pchaigno/revert-k8s-version-bump branch from 6631569 to 02be0a3 Compare April 21, 2023 20:11
@pchaigno pchaigno mentioned this pull request Apr 21, 2023
Merged
@pchaigno pchaigno marked this pull request as ready for review April 21, 2023 20:12
@pchaigno pchaigno requested review from a team as code owners April 21, 2023 20:12
zacharysarah
zacharysarah approved these changes Apr 21, 2023
View reviewed changes
Copy link
Contributor

@zacharysarah zacharysarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs rubberstamping to unblock

bimmlerd
bimmlerd approved these changes Apr 24, 2023
View reviewed changes
Copy link
Member

@bimmlerd bimmlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

contrib changes lgtm

@pchaigno pchaigno force-pushed the pr/pchaigno/revert-k8s-version-bump branch from 02be0a3 to 271aca7 Compare April 25, 2023 15:56
@pchaigno pchaigno requested a review from a team as a code owner April 25, 2023 15:56
@pchaigno pchaigno added dont-merge/blocked Another PR must be merged before this one. and removed dont-merge/blocked Another PR must be merged before this one. labels Apr 25, 2023
@pchaigno pchaigno force-pushed the pr/pchaigno/revert-k8s-version-bump branch from 271aca7 to 712355e Compare April 26, 2023 11:38
@pchaigno
Revert "k8s: add support for service.kubernetes.io/topology-mode"
fcd0cf7 
This reverts commit 8544406.

This commit seems to require the previous commit, a19558d ("Update
k8s tests and libraries to v1.27.0") which we'll need to revert. So
let's revert this one as well.

Signed-off-by: Paul Chaignon <paul@cilium.io>
@pchaigno
Revert "Update k8s tests and libraries to v1.27.0"
9c05169 
This reverts commit a19558d.

The k8s-upstream CI job is consistently failing since we merged this.
Let's revert.

Signed-off-by: Paul Chaignon <paul@cilium.io>
@pchaigno pchaigno force-pushed the pr/pchaigno/revert-k8s-version-bump branch from 712355e to 9c05169 Compare April 26, 2023 12:04
@pchaigno
Copy link
Member Author

/test-upstream-k8s

@pchaigno
Copy link
Member Author

/test

@pchaigno
Copy link
Member Author

/test-1.26-net-next

@pchaigno
Copy link
Member Author

/test-1.25-4.19

@pchaigno
Copy link
Member Author

/test-1.24-5.4

@pchaigno
Copy link
Member Author

k8s-1.26-kernel-net-next failed with known flake #24514. Other tests are passing except for the k8s-1.27-kernel-net-next job, but that one is expected: we just removed support for k8s 1.27.

@nbusseneau Ready to go!

@nbusseneau nbusseneau added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 26, 2023
@pchaigno pchaigno merged commit 40de910 into main Apr 26, 2023
58 of 60 checks passed
@pchaigno pchaigno deleted the pr/pchaigno/revert-k8s-version-bump branch April 26, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joamaki joamaki joamaki approved these changes

@zacharysarah zacharysarah zacharysarah approved these changes

@christarazi christarazi christarazi approved these changes

@nbusseneau nbusseneau nbusseneau approved these changes

@bimmlerd bimmlerd bimmlerd approved these changes

@youngnick youngnick youngnick approved these changes

@viktor-kurchenko viktor-kurchenko viktor-kurchenko approved these changes

@rolinh rolinh Awaiting requested review from rolinh rolinh is a code owner automatically assigned from cilium/vendor

Assignees
No one assigned
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/k8s Impacts the kubernetes API, or kubernetes -> cilium internals translation layers.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@pchaigno @joamaki @zacharysarah @christarazi @nbusseneau @bimmlerd @youngnick @viktor-kurchenko