Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci-datapath: Use QUAY_ORGANIZATION_DEV for Quay org name #25052

Merged
merged 1 commit into from Apr 24, 2023
Merged

ci-datapath: Use QUAY_ORGANIZATION_DEV for Quay org name #25052

merged 1 commit into from Apr 24, 2023

Conversation

michi-covalent
Copy link
Contributor

@michi-covalent michi-covalent commented Apr 21, 2023 •
edited

Use QUAY_ORGANIZATION_DEV environment variable as Quay organization name to be consistent with other workflow files.

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 21, 2023
@michi-covalent michi-covalent added the release-note/ci This PR makes changes to the CI. label Apr 21, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 21, 2023
@michi-covalent
Copy link
Contributor Author

✅ ci-datapath passed: https://github.com/cilium/cilium/actions/runs/4768548180/jobs/8477988744?pr=25052

removing the temporary commit and marking it ready for review.

@michi-covalent michi-covalent marked this pull request as ready for review April 21, 2023 21:14
@michi-covalent michi-covalent requested review from a team as code owners April 21, 2023 21:14
@michi-covalent
ci-datapath: Use QUAY_ORGANIZATION_DEV for Quay org name
628bb8c 
Use QUAY_ORGANIZATION_DEV environment variable as Quay organization name
to be consistent with other workflow files.

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
@michi-covalent
Copy link
Contributor Author

/test

julianwiedmann
julianwiedmann approved these changes Apr 22, 2023
View reviewed changes
Copy link
Member

@julianwiedmann julianwiedmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy & paste from similar workflows checks out 💯

viktor-kurchenko
viktor-kurchenko approved these changes Apr 24, 2023
View reviewed changes
Copy link
Contributor

@viktor-kurchenko viktor-kurchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 24, 2023
@michi-covalent michi-covalent merged commit cceba91 into main Apr 24, 2023
56 checks passed
@michi-covalent michi-covalent deleted the pr/michi/datapath branch April 24, 2023 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sayboras sayboras sayboras approved these changes

@julianwiedmann julianwiedmann julianwiedmann approved these changes

@viktor-kurchenko viktor-kurchenko viktor-kurchenko approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@michi-covalent @sayboras @julianwiedmann @viktor-kurchenko