Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipam/allocator: remove unused Allocator methods #25053

Merged
merged 1 commit into from Apr 24, 2023

Conversation

tklauser
Copy link
Member

The FirstPoolWithAvailableQuota and PoolExists methods are only used in test code since commit 24cb061 ("azure: Calculate available addresses based on subnet resource"). Remove or replace their use in the test code and remove the implementations.

@tklauser tklauser added kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact. sig/ipam IP address management, including cloud IPAM labels Apr 21, 2023
@tklauser tklauser requested a review from a team as a code owner April 21, 2023 21:04
@tklauser tklauser requested a review from gandro April 21, 2023 21:04
The FirstPoolWithAvailableQuota and PoolExists methods are only used in
test code since commit 24cb061 ("azure: Calculate available
addresses based on subnet resource"). Remove or replace their use in the
test code and remove the implementations.

Signed-off-by: Tobias Klauser <tobias@cilium.io>
@tklauser tklauser force-pushed the pr/tklauser/ipam-rm-poolexists branch from 4731138 to 2fecceb Compare April 21, 2023 21:10
@tklauser
Copy link
Member Author

/test

Copy link
Member

@gandro gandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find, thanks!

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 24, 2023
@tklauser tklauser merged commit 0ec4117 into cilium:main Apr 24, 2023
56 checks passed
@tklauser tklauser deleted the pr/tklauser/ipam-rm-poolexists branch April 25, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/ipam IP address management, including cloud IPAM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants