bpf: nodeport: handle result from encap ctx_redirect() in revDNAT path #25058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When redirecting a packet into the tunnel, return the result of that operation. Right now we're not reporting potential errors from the helper call. This will become more relevant with native XDP encapsulation, where ctx_redirect() can also turn the CTX_REDIRECT into a XDP_TX. Fixes: ff44164 ("bpf: Align rev_nodeport_lb{4,6} wrt egress GW tunnel mode") Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
julianwiedmann
added
kind/bug
|
/test |
borkmann
approved these changes
Apr 26, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When redirecting a packet into the tunnel, return the result of that operation. Right now we're not reporting potential errors from the helper call.
This will become more relevant with native XDP encapsulation, where ctx_redirect() can also turn the CTX_REDIRECT into a XDP_TX.
Fixes: ff44164 ("bpf: Align rev_nodeport_lb{4,6} wrt egress GW tunnel mode")