bpf: nodeport: remove lb4_populate_ports() #25063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lb4_extract_tuple() already extracts the full tuple, there's no need to extract the ports again. On top it also deals with L4 ports for fragmented packets. We just need to adjust __snat_v6_has_v4_complete() so that it load the ports from the right locations. We can also trust that the L4 proto type has been checked by lb4_extract_tuple(), and thus only need to special-case ICMP. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
julianwiedmann
added
sig/datapath
|
/test Job 'Cilium-PR-K8s-1.27-kernel-net-next' failed: Click to show.Test NameFailure OutputJenkins URL: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.27-kernel-net-next/88/ If it is a flake and a GitHub issue doesn't already exist to track it, comment |
borkmann
approved these changes
Apr 24, 2023
|
/mlh new-flake Cilium-PR-K8s-1.27-kernel-net-next 👍 created #25074 |
|
/test-1.27-net-next |
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lb4_extract_tuple() already extracts the full tuple, there's no need to extract the ports again. On top it also deals with L4 ports for fragmented packets. We just need to adjust __snat_v6_has_v4_complete() so that it load the ports from the right locations.
We can also trust that the L4 proto type has been checked by lb4_extract_tuple(), and thus only need to special-case ICMP.