k8s/watchers: Fix erroneous warning logs due to empty CIDRGroupRef #25072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christarazi
added
kind/bug
maintainer-s-little-helper
bot
added
dont-merge/needs-release-note-label
christarazi
force-pushed
the
pr/christarazi/fix-cidrgroup-erroneous-warning
branch
2 times, most recently
from
8d3287d
to
fa2e597
Compare
Previously, the logic to detect whether a CIDRGroupRef has been set did
not consider CNP policies which only reference a CIDR. This is relevant
because CIDRs and CIDRGroupRefs are mutually exclusive, i.e. oneOf
validation is applied on them.
This triggered the following warning log to be triggered quite often as
each update to the CNP would run through the translation logic:
```
level=warning msg="Unable to translate all cidr groups to cidrs" cidrGroupRef="[group-1 ]" ciliumNetworkPolicyName=tofqdn-dns-visibility error="cidr group \"group-1\" not found, skipping translation; cidr group \"\" not found, skipping translation" k8sApiVersion= k8sNamespace=default subsys=k8s-watcher
```
For example, the following will trigger the buggy behavior:
```
ingress:
- fromCIDRSet:
- cidr: "3.3.3.3/32"
```
With the fix, we detect that a CIDR has been set and therefore, we avoid
returning an empty CIDRGroupRef name.
Fixes: dd4aba4 ("k8s: Add support for cidrGroupRef field in
CNP/CCNP")
Fixes: cilium#25020
Signed-off-by: Chris Tarazi <chris@isovalent.com>
christarazi
force-pushed
the
pr/christarazi/fix-cidrgroup-erroneous-warning
branch
from
fa2e597
to
781665a
Compare
|
/test |
nebril
approved these changes
Apr 24, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the logic to detect whether a CIDRGroupRef has been set did
not consider CNP policies which only reference a CIDR. This is relevant
because CIDRs and CIDRGroupRefs are mutually exclusive, i.e. oneOf
validation is applied on them.
This triggered the following warning log to be triggered quite often as
each update to the CNP would run through the translation logic:
For example, the following will trigger the buggy behavior:
With the fix, we detect that a CIDR has been set and therefore, we avoid
returning an empty CIDRGroupRef name.
Fixes: dd4aba4 ("k8s: Add support for cidrGroupRef field in
CNP/CCNP")
Fixes: #25020
Signed-off-by: Chris Tarazi chris@isovalent.com