ci: fix clustermesh worfklows on stable branches #25089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbusseneau
added
area/CI
|
My fault, sorry for the inconvenience. The checkout step is required to retrieve the helm chart used during installation, but it can be moved after cluster creation. |
|
CI passed: https://github.com/cilium/cilium/actions/runs/4788606197 |
nbusseneau
force-pushed
the
pr/fix-clustermesh-stable
branch
from
ed930a3
to
a3db4b4
Compare
viktor-kurchenko
approved these changes
Apr 26, 2023
nbusseneau
added
the
ready-to-merge
giorio94
requested changes
Apr 26, 2023
giorio94
removed
the
ready-to-merge
The clustermesh workflows currently fail on stable branches as they expect `.github/kind-config.yaml.tmpl` to be present, but this file is only present on `main`. We still need to checkout the branch code so as to retrieve the Helm chart that will be used in the cluster via `cilium install`. We move the checkout part just right before we install Cilium. Thus, the Kind template file on `main` is used for all worfkows. Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
nbusseneau
force-pushed
the
pr/fix-clustermesh-stable
branch
from
a3db4b4
to
d7534a4
Compare
|
CI passed: https://github.com/cilium/cilium/actions/runs/4809296042 |
nbusseneau
force-pushed
the
pr/fix-clustermesh-stable
branch
from
d7534a4
to
13fb6a8
Compare
nbusseneau
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The clustermesh workflows currently fail on stable branches as they expect
.github/kind-config.yaml.tmplto be present, but this file is only present onmain.It seems the template file is the only reason we need to checkout the repository, as we do not use any other file from the repository in subsequent steps, so we fix this by removing the checkout of the current branch since we already checkout the
mainbranch in a prior step.Thus, the template file on
mainis used for all worfkows.