daemon: use netlink for managed neighbor support probe #25134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgo3
added
sig/datapath
maintainer-s-little-helper
bot
added
dont-merge/needs-release-note-label
rgo3
added
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
|
Tested this probe logic manually on 6.1 and 5.10. It didn't error out on either version, probing managed neighbor support conclusively (available on 6.1, not available on 5.10). |
|
/test |
rgo3
force-pushed
the
rewrite-neighbor-support-probe
branch
from
aef3117
to
5887743
Compare
|
/test |
|
runtime hit #22373, rerunning. Also marking as ready to review. |
|
/test-runtime |
lmb
reviewed
May 4, 2023
ti-mo
reviewed
May 10, 2023
rgo3
force-pushed
the
rewrite-neighbor-support-probe
branch
from
5887743
to
2f0cc75
Compare
rgo3
force-pushed
the
rewrite-neighbor-support-probe
branch
from
2f0cc75
to
ddfbaa5
Compare
ti-mo
reviewed
May 12, 2023
ti-mo
requested changes
May 12, 2023
tklauser
reviewed
May 12, 2023
lmb
reviewed
May 12, 2023
rgo3
force-pushed
the
rewrite-neighbor-support-probe
branch
from
ddfbaa5
to
b2bfd37
Compare
ti-mo
reviewed
May 16, 2023
ti-mo
approved these changes
May 16, 2023
This helper allows tests for feature probes to be skipped on kernel versions that are known to lack the feature. Signed-off-by: Timo Beckers <timo@isovalent.com>
With this commit we refactor the probe logic that checks for the existence of a certain helper as this could break on older distro kernel that have backported the commit we probed for. Using actual netlink calls to probe for managed neighbor support will only succeed if the underlying kernel actually supports it. Fixes cilium#20694. Signed-off-by: Robin Gögge <r.goegge@isovalent.com>
rgo3
force-pushed
the
rewrite-neighbor-support-probe
branch
from
b2bfd37
to
e7d8d4a
Compare
|
/test |
lmb
approved these changes
May 17, 2023
tklauser
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we refactor the probe logic that checks for the existence of a certain helper as this could break on older distro kernels that have backported the commit we probed for.
Using actual netlink calls to probe for managed neighbor support will only succeed if the underlying kernel actually supports it.
Fixes #20694.