test: Avoid spamming logs in monitor aggregation test #25152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchaigno
added
area/CI-improvement
pchaigno
force-pushed
the
improve-monitor-aggregation-tests
branch
from
d13cfe7
to
b0284c2
Compare
|
/test |
gentoo-root
approved these changes
Apr 27, 2023
The monitor aggregation tests are currently spamming the logs because they dump useless matches from regular expressions. Let's remove that. Most of the log spam comes from the use of %+v to dump the regexp matches. That doesn't even work properly and ends up dumping a huge matrix of integers. Given we retry this step until it eventually succeeds, this can add up to several megabytes of logs. In addition to removing this dump of the regexp matches, we also switch the checkMonitorOutput function to return an error instead of a boolean. The consequence of that change is that the Eventually block will display the actual error message from checkMonitorOutput on failure. The test logs won't contain one error message (GinkgoPrint) per failure, but only the last error message we got before timing out. I believe that's what we want because: 1) it surfaces the actual error in the ginkgo results instead of telling us "expected true, got false" (duh!) and (2) in logs, we only care about the last error message. Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
force-pushed
the
improve-monitor-aggregation-tests
branch
from
b0284c2
to
e056a37
Compare
|
The last force push only updated the commit description to account for the review discussion. All Jenkins test were passing before that so merging without rerunning. Thanks for the reviews Viktor and Maxim! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The monitor aggregation tests are currently spamming the logs because they dump useless matches from regular expressions. Let's remove that.