workflows: Fix owner tag for stable branch workflows #25158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbusseneau
approved these changes
Apr 27, 2023
| @@ -148,7 +148,7 @@ jobs: | |||
| elif [ "${{ github.event_name }}" = "schedule" ]; then | |||
| curl https://api.github.com/repos/cilium/cilium/branches/v1.11 > branch.json | |||
| SHA=$(jq -r '.commit.sha' branch.json) | |||
| OWNER=v1.11 | |||
| OWNER=v111 | |||
There was a problem hiding this comment.
LGTM.
Just curious why don't you want to use a hyphen instead of a dot (e.g.: v1-11)?
There was a problem hiding this comment.
Because I got scared of any special character. If it can't handle dots, god knows what it can handle 🤷
Switched to v1-x. If it breaks, you'll owe me the fix 😝
viktor-kurchenko
approved these changes
Apr 27, 2023
GKE-based workflows on stable branches are currently failing with:
ERROR: (gcloud.container.clusters.create) ResponseError: code=400, message=Invalid field 'resource_labels.value': "v1.11". It must only contain lowercase letters ([a-z]), numeric characters ([0-9]), underscores (_) and dashes (-). International characters are allowed.
This commit therefore changes the owner tag for all workflows, to remove
the dot character.
Fixes: 335341b ("workflows: Fix SHA for scheduled runs on stable branches")
Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
force-pushed
the
pr/pchaigno/fix-owner-stable-branch-workflows
branch
from
405c55d
to
ccfa2af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GKE-based workflows on stable branches are currently failing with:
This commit therefore changes the owner tag for all workflows, to remove the dot character.
Fixes: #25080.