Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh/workflows: Rename ci-datapath to ci-e2e #25164

Merged
merged 1 commit into from May 1, 2023

Conversation

brb
Copy link
Member

@brb brb commented Apr 27, 2023

The GHAs are no longer testing only the datapath features.

The ownership will be addressed by [1].

[1]: cilium/cilium-cli#1549

@brb brb added area/CI-improvement Topic or proposal to improve the Continuous Integration workflow release-note/ci This PR makes changes to the CI. labels Apr 27, 2023
@brb brb requested review from a team as code owners April 27, 2023 12:48
@viktor-kurchenko
Copy link
Contributor

There are few lines like: description: Datapath tests in progress....
Should they be renamed also?

Copy link
Contributor

@viktor-kurchenko viktor-kurchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@brb
Copy link
Member Author

brb commented Apr 28, 2023

There are few lines like: description: Datapath tests in progress....

@viktor-kurchenko Nice catch! Let me update in a sec.

@brb brb force-pushed the pr/brb/rename-ci-dp-to-e2e branch from 98652d7 to f2cdac1 Compare April 28, 2023 14:19
@brb brb added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 1, 2023
@brb
Copy link
Member Author

brb commented May 1, 2023

cc @nbusseneau : Once this PR has been merged, we need to update the required jobs.

The GHAs are no longer testing only the datapath features.

The ownership will be addressed by [1].

[1]: cilium/cilium-cli#1549

Signed-off-by: Martynas Pumputis <m@lambda.lt>
@brb brb force-pushed the pr/brb/rename-ci-dp-to-e2e branch from f2cdac1 to 475e96f Compare May 1, 2023 13:18
@joestringer joestringer added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. and removed ready-to-merge This PR has passed all tests and received consensus from code owners to merge. labels May 1, 2023
@joestringer
Copy link
Member

ConformanceIngress CI failed with strange infra-looking issue:

Run curl -sSL --remote-name-all [https://github.com/cilium/cilium-cli/releases/download/v0.13.2/cilium-linux-amd64.tar.gz{](https://github.com/cilium/cilium-cli/releases/download/v0.13.2/cilium-linux-amd64.tar.gz%7B),.sha[2](https://github.com/cilium/cilium/actions/runs/4851488367/jobs/8645379148?pr=25164#step:4:2)56sum}
  curl -sSL --remote-name-all [https://github.com/cilium/cilium-cli/releases/download/v0.13.2/cilium-linux-amd64.tar.gz{](https://github.com/cilium/cilium-cli/releases/download/v0.13.2/cilium-linux-amd64.tar.gz%7B),.sha256sum}
  sha256sum --check cilium-linux-amd64.tar.gz.sha256sum
  sudo tar xzvfC cilium-linux-amd64.tar.gz /usr/local/bin
  rm cilium-linux-amd64.tar.gz{,.sha256sum}
  cilium version
  shell: /usr/bin/bash -e {0}
  env:
    cilium_cli_version: v0.1[3](https://github.com/cilium/cilium/actions/runs/4851488367/jobs/8645379148?pr=25164#step:4:3).2
    kind_version: v0.17.0
    kind_config: .github/kind-config.yaml
    metallb_version: 0.12.1
    timeout: 5m
    QUAY_ORGANIZATION: cilium
    QUAY_ORGANIZATION_DEV: cilium
sha256sum: WARNING: 1 computed checksum did NOT match
cilium-linux-amd6[4](https://github.com/cilium/cilium/actions/runs/4851488367/jobs/8645379148?pr=25164#step:4:4).tar.gz: FAILED
Error: Process completed with exit code 1.

I see that this PR only makes changes to completely unrelated workflows, so the above does not need to block the merging (however, the standard process is to triage, link failures and re-run CI).

@joestringer joestringer merged commit bead3ac into main May 1, 2023
42 of 43 checks passed
@joestringer joestringer deleted the pr/brb/rename-ci-dp-to-e2e branch May 1, 2023 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI-improvement Topic or proposal to improve the Continuous Integration workflow ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants