Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invert --hubble-monitor-events logic to be an allowlist #25167

Merged
merged 1 commit into from Apr 27, 2023
Merged

Invert --hubble-monitor-events logic to be an allowlist #25167

merged 1 commit into from Apr 27, 2023

Conversation

epk
Copy link
Contributor

@epk epk commented Apr 27, 2023 •
edited

Follow up to #24828

Addresses @marqc's comments.

#24828 was excluding events set by --hubble-monitor-events instead of monitoring them

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!
Bugfix: Invert `--hubble-monitor-events` logic to be an allowlist

@epk
Hubble Monitor Filter: invert logic
e28bfc4 
Signed-off-by: Aditya Sharma <aditya.sharma@shopify.com>
@epk epk requested a review from a team as a code owner April 27, 2023 13:41
@epk epk requested a review from kaworu April 27, 2023 13:41
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 27, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Apr 27, 2023
@epk epk mentioned this pull request Apr 27, 2023
Merged
8 tasks
@epk
Copy link
Contributor Author

epk commented Apr 27, 2023

Also, could we backport #24828 + this PR to 1.12 and 1.13?

michi-covalent
michi-covalent approved these changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@michi-covalent michi-covalent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for following on this quickly ❤️ 💯

@michi-covalent
Copy link
Contributor

/test

@michi-covalent
Copy link
Contributor

Also, could we backport #24828 + this PR to 1.12 and 1.13?

usually we only backport bug fixes to stable branches. the criteria for backporting is defined here => https://docs.cilium.io/en/v1.13/contributing/release/backports/#backport-criteria. not sure if #24828 can be considered a bug fix, it's more of a performance improvement 🤔

@michi-covalent michi-covalent added the release-note/bug This PR fixes an issue in a previous release of Cilium. label Apr 27, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 27, 2023
kaworu
kaworu approved these changes Apr 27, 2023
View reviewed changes
Copy link
Member

@kaworu kaworu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix @epk!

marqc
marqc approved these changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@marqc marqc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 27, 2023
@pchaigno pchaigno merged commit 0426fce into cilium:main Apr 27, 2023
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaworu kaworu kaworu approved these changes

@marqc marqc marqc approved these changes

@michi-covalent michi-covalent michi-covalent approved these changes

Assignees
No one assigned
Labels
kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@epk @michi-covalent @kaworu @marqc @pchaigno