bpf,make: add ability to run bpf unit tests in the Cilium builder #25173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
ldelossa
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
ldelossa
force-pushed
the
ldelossa/containerize-ebpf-unit-tests
branch
from
e51594b
to
7f6c79c
Compare
|
Don't think we need to run full suite for this, smoke tests cover running the effected eBPF unit tests, and this passes. Just need reviews. |
ldelossa
force-pushed
the
ldelossa/containerize-ebpf-unit-tests
branch
from
7f6c79c
to
4fdad2b
Compare
This commit adds a top level Makefile target for running eBPF unit tests within the Cilium builder container. The Cilium builder container ensures all the dependencies necessary to build and run the tests are present. After this commit, running `make run_bpf_tests` from the root of the repo will run the tests in a container, while running the same target in the `./test` directory will run the tests locally, outside of the container Signed-off-by: Louis DeLosSantos <louis.delos@isovalent.com>
ldelossa
force-pushed
the
ldelossa/containerize-ebpf-unit-tests
branch
from
4fdad2b
to
0b42443
Compare
viktor-kurchenko
approved these changes
May 2, 2023
ldelossa
added
the
ready-to-merge
|
Unrelated Travis CI issue, marking ready to merge with two approvals. |
|
Can we do something about the Travis issue? Ignoring it won't make it go away. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a top level Makefile target for running eBPF unit tests within the Cilium builder container.
The Cilium builder container ensures all the dependencies necessary to build and run the tests are present.
After this commit, running
make run_bpf_testsfrom the root of the repo will run the tests in a container, while running the same target in the./testdirectory will run the tests locally, outside of the container