bpf, cilium/cmd: remove unused hidden cilium bpf migrate-map sub-command
#25196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's unused in the datapath since commit bd31f7d ("datapath: Drop nodeport_must_drop_remote constraint"). Signed-off-by: Tobias Klauser <tobias@cilium.io>
tklauser
added
sig/datapath
tklauser
added
the
area/cli
…mmand The `cilium bpf migrate-map sub-command` was introduced in 4305f92 ("cilium-migrate-map: port from C to Go") as a temporary CLI wrapper around the logic to migrate bpf maps from bpf/init.sh. Since commit d38dda4 ("init.sh,loader: load overlay programs in Go") that task is performed from within the agent using the same Go code and thus making the migrate-map sub-command obsolete. The sub-command is hidden and was only used in bpf/init.sh, so remove it directly without deprecating it first. Signed-off-by: Tobias Klauser <tobias@cilium.io>
tklauser
force-pushed
the
pr/tklauser/rm-cilium-migrate-map
branch
from
4b2c1f0
to
097e8f0
Compare
ti-mo
approved these changes
Apr 28, 2023
Merge conflicts when rebasing one of my WIP branches where I had hacks in |
|
/test |
|
/ci-e2e |
squeed
approved these changes
May 2, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
cilium bpf migrate-map sub-commandwas introduced in 4305f92("cilium-migrate-map: port from from C to Go") as a temporary CLI
wrapper around the logic to migrate bpf maps from
bpf/init.sh. Sincecommit d38dda4 ("init.sh,loader: load overlay programs in Go") that
task is performed from within the agent using the same Go code and thus
making the migrate-map sub-command obsolete. The sub-command is hidden
and was only used in
bpf/init.sh, so remove it directly withoutdeprecating it first.