Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation to ensure l7proxy cannot be disabled when Ingress is enabled #25215

Merged
merged 1 commit into from May 4, 2023
Merged

Add validation to ensure l7proxy cannot be disabled when Ingress is enabled #25215

merged 1 commit into from May 4, 2023

Conversation

youngnick
Copy link
Contributor

Adds validation to ensure that trying to enable Ingress or Gateway API support while having l7proxy disabled will cause installs to fail.

Fixes: #21354
Fixes: #22789
Updates: #22698

Added validation to ensure that enabling Ingress or Gateway API support while l7proxy is disabled will fail, as this is an incompatible configuration.

@youngnick youngnick added release-note/minor This PR changes functionality that users may find relevant to operating Cilium. area/servicemesh GH issues or PRs regarding servicemesh labels May 1, 2023
@youngnick youngnick requested review from a team as code owners May 1, 2023 10:44
@youngnick youngnick requested a review from squeed May 1, 2023 10:44
@youngnick
Copy link
Contributor Author

/test

@youngnick
Copy link
Contributor Author

Looks like the CI image build failed due to a package pull timeout, and then everything failed, retesting.

/test

@youngnick
Add validation to ensure l7proxy cannot be disabled when Ingress is e…
fc0a6a4 
…nabled

Signed-off-by: Nick Young <nick@isovalent.com>
@aanm aanm added needs-backport/1.12 needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels May 2, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.13.3 May 2, 2023
@aanm aanm added release-note/bug This PR fixes an issue in a previous release of Cilium. and removed release-note/minor This PR changes functionality that users may find relevant to operating Cilium. labels May 2, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.12.10 May 2, 2023
@squeed
Copy link
Contributor

squeed commented May 2, 2023

@youngnick do you know if any of the Jenkins tests touch these fields? If not, we can skip the full test suite.

@youngnick
Copy link
Contributor Author

I don't think so - I also checked with @sayboras to be sure though. 😆

@youngnick youngnick added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 3, 2023
@joestringer joestringer merged commit ea404cf into cilium:main May 4, 2023
43 checks passed
@YutaroHayakawa YutaroHayakawa mentioned this pull request May 10, 2023
Merged
14 tasks
@YutaroHayakawa YutaroHayakawa added backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. and removed needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels May 10, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.13 in 1.13.3 May 10, 2023
@YutaroHayakawa YutaroHayakawa mentioned this pull request May 10, 2023
Merged
7 tasks
@jibi jibi mentioned this pull request May 15, 2023
Merged
3 tasks
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.12 in 1.12.10 May 15, 2023
@YutaroHayakawa YutaroHayakawa added needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch and removed backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. labels May 15, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.13 to Needs backport from main in 1.13.3 May 15, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.13 to Needs backport from main in 1.13.3 May 15, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.12 to Needs backport from main in 1.12.10 May 15, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.12 to Needs backport from main in 1.12.10 May 15, 2023
@thorn3r thorn3r removed needs-backport/1.12 needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels May 15, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed this from Needs backport from main in 1.13.3 May 15, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed this from Needs backport from main in 1.12.10 May 15, 2023
@thorn3r
Copy link
Contributor

thorn3r commented May 15, 2023

removed needs-backport labels from this PR until a bugfix is submitted, re: l7proxy vs. l7Proxy. cc: @YutaroHayakawa

This was referenced May 25, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squeed squeed squeed approved these changes

Assignees
No one assigned
Labels
area/servicemesh GH issues or PRs regarding servicemesh ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
None yet
Milestone
No milestone
7 participants
@youngnick @squeed @thorn3r @jibi @joestringer @aanm @YutaroHayakawa