garp: Introduce Gratuitous ARP Cell #25254
Conversation
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
markpash
force-pushed
the
pr/markpash/gratuitous-arp-cell
branch
from
995c3a8
to
22d41d5
Compare
markpash
added
kind/feature
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
markpash
force-pushed
the
pr/markpash/gratuitous-arp-cell
branch
from
22d41d5
to
64ad887
Compare
|
👋 We used to have a well tested arping library which later got removed - 8a8ac6c. Maybe we could reuse it? |
The library you point out creates ARP requests and parses replies, that is not what we need since we are sending ARP Replies out without getting a request. |
pkg/datapath/garp/garp.go
Outdated
|
|
||
| // Send implements Sender | ||
| func (s *sender) Send(ip netip.Addr) error { | ||
| arpClient, err := arp.Dial(s.iface) |
There was a problem hiding this comment.
Do we need to create the client each time or can it be initialized once in newGARPSender?
There was a problem hiding this comment.
The client that's created uses a raw socket underneath. I'm worried about keeping a raw socket open all the time, and figured it would be better to create and destroy on-demand. If there's no issue with keeping raw sockets open, then I'm happy to create the client in the constructor.
markpash
force-pushed
the
pr/markpash/gratuitous-arp-cell
branch
2 times, most recently
from
c75356a
to
b65238d
Compare
In addition to @dylandreimerink 's comments, I also believe the current approach is less code, relies on an existing dependency, and that the library used is also a well-tested one. |
Gratuitous ARP is the process of broadcasting unsolicited ARP packets, usually with the goal of informing all Layer 2 devices of a new IP/MAC association on the L2 domain and forcing any switches to relearn the MAC address. Here we add the `garp` cell. While not really useful yet, the purpose is to provide a simple Hive Cell that implements the new `garp.Sender` interface, so that any other Cell may send gratuitous ARP packets. Signed-off-by: Mark Pashmfouroush <mark@isovalent.com>
markpash
force-pushed
the
pr/markpash/gratuitous-arp-cell
branch
from
b65238d
to
4eed933
Compare
|
/test |
markpash
added
ready-to-merge
Gratuitous ARP is the process of broadcasting unsolicited ARP packets, usually with the goal of informing all Layer 2 devices of a new IP/MAC association on the L2 domain and forcing any switches to relearn the MAC address.
Here we add the
garpcell. While not really useful yet, the purpose is to provide a simple Hive Cell that implements the newgarp.Senderinterface, so that any other Cell may send gratuitous ARP packets.Signed-off-by: Mark Pashmfouroush mark@isovalent.com