identity/cache: fix panic when re-init of cache after close. #25269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
|
/test |
1 similar comment
|
/test |
tommyp1ckles
added
the
release-note/minor
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
tommyp1ckles
added
area/CI
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
nebril
approved these changes
May 8, 2023
The cache appears to be intended to tolerate being initialized, closed then reinitialized. However the events channel is not reset correctly leading to a double close panic in tests. This ensures that the events channel is set to nil after being closed, and checked upon further closes. As well, if init is called on Close()'d cache, the events channel/watcher will be recreated. Also, added tests to check functionality/correctness in this case. Fixes: cilium#25235 Signed-off-by: Tom Hadlaw <tom.hadlaw@isovalent.com>
tommyp1ckles
force-pushed
the
pr/tp/fix-identity-cache-panic
branch
from
2d259a0
to
1e731b8
Compare
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cache appears to be intended to tolerate being initialized, closed then reinitialized. However the events channel is not reset correctly leading to a double close panic in tests.
This ensures that the events channel is set to nil after being closed, and checked upon further closes.
As well, if init is called on Close()'d cache, the events channel/watcher will be recreated.
Also, added tests to check functionality/correctness in this case.
Fixes: #25235