k8s: Use slim Node in LocalNode Resource and K8s watchers #25282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
joamaki
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
joamaki
changed the title
|
/test |
joamaki
force-pushed
the
pr/joamaki/use-slim-node
branch
from
4c67d77
to
e2fafc7
Compare
dylandreimerink
approved these changes
May 8, 2023
joamaki
force-pushed
the
pr/joamaki/use-slim-node
branch
from
e2fafc7
to
348a4b3
Compare
|
/test |
tommyp1ckles
approved these changes
May 16, 2023
|
/test |
joamaki
added
the
ready-to-merge
|
@joamaki None of the e2e tests were triggered for your last |
The struct wrapping and boxing of resource creates an unnecessary pointer indirection. Just newtyping Resource[T] is enough. Signed-off-by: Jussi Maki <jussi@isovalent.com>
The LocalNode resource now uses slim_corev1.Node which avoids the unnecessary conversions to it from v1.Node. Adds ProviderID to slim_corev1.Node as it was needed by BGP. Signed-off-by: Jussi Maki <jussi@isovalent.com>
joamaki
force-pushed
the
pr/joamaki/use-slim-node
branch
from
348a4b3
to
82c748d
Compare
joamaki
removed
the
ready-to-merge
Huh, that's odd. I'll rebase and try again and if that doesn't do it, I'll close and reopen. |
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were performing unnecessary conversions from corev1.Node to slim_corev1.Node.
Only blocker for using slim_corev1.Node was the missing ProviderID.