hive: Make timer job test less flaky #25308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrajahalme
added
area/CI
jrajahalme
force-pushed
the
hive-timer-job-test-less-flaky
branch
from
9f87d7f
to
d019f16
Compare
dylandreimerink
approved these changes
May 8, 2023
giorio94
approved these changes
May 8, 2023
jrajahalme
force-pushed
the
hive-timer-job-test-less-flaky
branch
from
d019f16
to
d86d125
Compare
job_test.go would typically fail on local test runs on Linux on arm64 VM on a Mac. Fix this by not trying to assert the observed timer intervals, but just make sure the timer function is called repeatedly so that we catch regressions of timer not functioning at all. Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
jrajahalme
force-pushed
the
hive-timer-job-test-less-flaky
branch
from
d86d125
to
8050476
Compare
giorio94
approved these changes
May 8, 2023
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
job_test.gowould typically fail on local test runs on Linux on arm64 VMon a Mac. Fix this by not trying to assert the observed timer intervals,
but just make sure the timer function is called repeatedly so that we
catch regressions of timer not functioning at all.