hive,docs: Improved the pkg/hive/job documentation #25312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylandreimerink
added
area/documentation
bimmlerd
approved these changes
May 8, 2023
zacharysarah
approved these changes
May 17, 2023
There was a problem hiding this comment.
@dylandreimerink Thanks for adding these improvements! ⭐ I noted one non-blocking option for slightly different wording, in either case LGTM.
PR cilium#24558 got merged before the docs feedback was in, this PR applies the suggested improvements to the Hive docs related to jobs. Signed-off-by: Dylan Reimerink <dylan.reimerink@isovalent.com>
dylandreimerink
force-pushed
the
feature/job-docs-improvement
branch
from
5068e12
to
1340770
Compare
|
/test |
|
Tests are not completing due to a borked Jenkins, this change only contains docs changes anyhow for which the tests did pass so marking as ready-to-merge |
dylandreimerink
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #24558 got merged before the docs feedback was in, this PR applies the suggested improvements to the Hive docs related to jobs.