Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpf: nat: fix L4 csum case in ingress path for ICMP-embedded SCTP #25315

Merged
merged 1 commit into from May 9, 2023
Merged

bpf: nat: fix L4 csum case in ingress path for ICMP-embedded SCTP #25315

merged 1 commit into from May 9, 2023

Conversation

julianwiedmann
Copy link
Member

We can't adjust the L4 csum for a SCTP packet yet.

@julianwiedmann julianwiedmann added kind/bug This is a bug in the Cilium logic. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. release-note/misc This PR makes changes that have no direct user impact. labels May 8, 2023
@julianwiedmann julianwiedmann requested a review from a team as a code owner May 8, 2023 13:09
@julianwiedmann
Copy link
Member Author

/test

@julianwiedmann
bpf: nat: fix L4 csum case in ingress path for ICMP-embedded SCTP
0f61196 
We can't adjust the L4 csum for a SCTP packet yet.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann
Copy link
Member Author

julianwiedmann commented May 8, 2023 •
edited by maintainer-s-little-helper bot

/test

Job 'Cilium-PR-K8s-1.25-kernel-4.19' failed:

Click to show.

Test Name

K8sDatapathConfig Host firewall With VXLAN

Failure Output

FAIL: Failed to reach 192.168.56.11:80 from testclient-5fnxv

Jenkins URL: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.25-kernel-4.19/2036/

If it is a flake and a GitHub issue doesn't already exist to track it, comment /mlh new-flake Cilium-PR-K8s-1.25-kernel-4.19 so I can create one.

Then please upload the Jenkins artifacts to that issue.

@julianwiedmann
Copy link
Member Author

https://jenkins.cilium.io/job/Cilium-PR-K8s-1.25-kernel-4.19/2036/testReport/junit/Suite-k8s-1/25/K8sDatapathConfig_Host_firewall_With_VXLAN/ is #15455

@julianwiedmann
Copy link
Member Author

julianwiedmann commented May 9, 2023 •
edited by maintainer-s-little-helper bot

/test-1.25-4.19

Job 'Cilium-PR-K8s-1.25-kernel-4.19' hit: #24697 (86.16% similarity)

@maintainer-s-little-helper maintainer-s-little-helper bot mentioned this pull request May 9, 2023
Closed
@julianwiedmann
Copy link
Member Author

Moar HostFW flakes (thanks mlh!) in https://jenkins.cilium.io/job/Cilium-PR-K8s-1.25-kernel-4.19/2051/

@julianwiedmann
Copy link
Member Author

/test-1.25-4.19

@julianwiedmann julianwiedmann added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 9, 2023
@julianwiedmann julianwiedmann merged commit e7c6cfc into cilium:main May 9, 2023
57 checks passed
@julianwiedmann julianwiedmann deleted the 1.14-nat-csum branch May 9, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gentoo-root gentoo-root gentoo-root approved these changes

Assignees
No one assigned
Labels
kind/bug This is a bug in the Cilium logic. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@julianwiedmann @gentoo-root