bpf: clean up some revalidate_data() users #25337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianwiedmann
added
sig/datapath
|
/test |
julianwiedmann
force-pushed
the
1.14-revalidate-data
branch
from
f793f5b
to
aed38b1
Compare
|
/test |
julianwiedmann
force-pushed
the
1.14-revalidate-data
branch
from
aed38b1
to
1df740d
Compare
|
/test |
julianwiedmann
force-pushed
the
1.14-revalidate-data
branch
from
1df740d
to
8a6594b
Compare
|
/ci-verifier |
|
Commit 0664e3f4010b275282fa1ef16b45d7c7f59b20fd does not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
maintainer-s-little-helper
bot
added
the
dont-merge/needs-sign-off
|
/ci-verifier |
julianwiedmann
force-pushed
the
1.14-revalidate-data
branch
from
0664e3f
to
213da4d
Compare
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-sign-off
|
/ci-verifier |
julianwiedmann
force-pushed
the
1.14-revalidate-data
branch
from
213da4d
to
dd6a8f8
Compare
|
/ci-verifier |
julianwiedmann
force-pushed
the
1.14-revalidate-data
branch
from
dd6a8f8
to
58b9183
Compare
|
/ci-l4lb |
julianwiedmann
force-pushed
the
1.14-revalidate-data
branch
2 times, most recently
from
d897c5f
to
eb33923
Compare
Don't bother validating an IPv4 header when the packet is actually IPv6. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
Nothing uses the L3 header after this revalidation. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
When called in from-overlay or from-netdev, we already validated the IPv6 header and can skip the validation inside nodeport_lb6(). Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
julianwiedmann
force-pushed
the
1.14-revalidate-data
branch
from
eb33923
to
0632883
Compare
|
/test |
|
/test-1.24-5.4 |
aspsk
approved these changes
Jun 9, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
|
GH ginkgo fails are #25964 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some completely innocent cleanups to our
revalidate_data()usage.