New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert and fix ip rules #25350
Merged
Merged
Revert and fix ip rules #25350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
The author needs to describe the release impact of these changes.
label
May 10, 2023
NikAleksandrov
force-pushed
the
revert-and-fix-ip-rules
branch
5 times, most recently
from
May 10, 2023 10:09
f2739c2
to
348bba8
Compare
The endpoint's IP is not released int the function Delete, it is release in the function EndpointDeleted. This comments will confused the code reader. Signed-off-by: pengbinbin1 <pengbiny@163.com>
Update vishvananda/netlink/ so we can make use of fib rule RTA_PROTOCOL attribute. Signed-off-by: Nikolay Aleksandrov <nikolay@isovalent.com>
This reverts commit 53fef54. Signed-off-by: Nikolay Aleksandrov <nikolay@isovalent.com>
This reverts commit 368ec8e. Signed-off-by: Nikolay Aleksandrov <nikolay@isovalent.com>
This reverts commit ed5114d. Signed-off-by: Nikolay Aleksandrov <nikolay@isovalent.com>
This reverts commit dbce5f1. Signed-off-by: Nikolay Aleksandrov <nikolay@isovalent.com>
This reverts commit 9e62a84. Signed-off-by: Nikolay Aleksandrov <nikolay@isovalent.com>
This reverts commit 5fb791d. Signed-off-by: Nikolay Aleksandrov <nikolay@isovalent.com>
This reverts commit 0f3e989. Signed-off-by: Nikolay Aleksandrov <nikolay@isovalent.com>
This reverts commit 3271cb2. Signed-off-by: Nikolay Aleksandrov <nikolay@isovalent.com>
This reverts commit afdc51f. Signed-off-by: Nikolay Aleksandrov <nikolay@isovalent.com>
This reverts commit 9b5e74b. Signed-off-by: Nikolay Aleksandrov <nikolay@isovalent.com>
This reverts commit 2b6d5c4. Signed-off-by: Nikolay Aleksandrov <nikolay@isovalent.com>
This reverts commit 05593ee. Signed-off-by: Nikolay Aleksandrov <nikolay@isovalent.com>
This reverts commit a9cad19. Signed-off-by: Nikolay Aleksandrov <nikolay@isovalent.com>
Remove the IPv6-specific DeleteRuleIPv6() and add a family argument to DeleteRule so we can use the same function for both families. Signed-off-by: Nikolay Aleksandrov <nikolay@isovalent.com>
This reverts commit 9d60341. Signed-off-by: Nikolay Aleksandrov <nikolay@isovalent.com>
NikAleksandrov
force-pushed
the
revert-and-fix-ip-rules
branch
from
May 10, 2023 10:09
348bba8
to
5ae2df5
Compare
Removing release blocker 1.14 as this is already in v1.14: a63aabc |
jrajahalme
removed
the
release-blocker/1.14
This issue will prevent the release of the next version of Cilium.
label
Oct 17, 2023
julianwiedmann
added
affects/v1.13
This issue affects v1.13 branch
and removed
needs-backport/1.13
This PR / issue needs backporting to the v1.13 branch
labels
Feb 10, 2024
I dropped the PR from the 1.13 backport queue for now, let's not set wrong expectations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
affects/v1.13
This issue affects v1.13 branch
backport/author
The backport will be carried out by the author of the PR.
release-note/misc
This PR makes changes that have no direct user impact.
sig/datapath
Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This set is a second attempt at reverting the revert PR #24756, which was reverting #24288 and #24577
The upgrade problem mentioned in PR #24756 was due to wrongfully assuming that DeleteRule()
was handling both IPv4 and IPv6. Turns out there was a specific DeleteRuleIPv6() function
which seems unnecessary, so there is 1 additional patch prior to the last revert which changes DeleteRule() and adds
a new family argument, then removes DeleteRuleIPv6(). The problem manifested only when both IPv4 and IPv6 were
enabled due to the IPv6 rule deletion which was actually removing the IPv4 rule.
Note I have removed the "Revert revert" in the patch titles to make checkpatch happy.
The upgrade was tested as: