docs: Clarify the steps to update images #25367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gentoo-root
added
the
release-note/misc
qmonnet
added
the
area/documentation
Clarify the order in which the pull requests have to be merged for a successful update of cilium-builder and cilium-runtime images. Replace test/Vagrantfile with vagrant_box_defaults.rb to reflect the new location of SERVER_VERSION, that changed at least a few years ago. Mention all *SERVER_VERSION fields that need to be updated. Clarify the step where you need to trigger the box builds. Signed-off-by: Maxim Mikityanskiy <maxim@isovalent.com>
gentoo-root
force-pushed
the
fix-images-docs
branch
from
84a2ecf
to
db64898
Compare
|
@qmonnet, I updated the patch to include more clarifications, please tell me if it still looks good to you. |
gentoo-root
added
the
ready-to-merge
|
Setting ready-to-merge, the full CI shouldn't be needed for a documentation change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify the order in which the pull requests have to be merged for a successful update of cilium-builder and cilium-runtime images.
Replace test/Vagrantfile with vagrant_box_defaults.rb to reflect the new location of SERVER_VERSION, that changed at least a few years ago.