bpf/init.sh: move node config generation to Go #25380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
rgo3
added
sig/loader
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
|
/test |
rgo3
force-pushed
the
initsh-remove-nodeconfig-gen
branch
from
ac8a933
to
660411d
Compare
|
/test |
rgo3
force-pushed
the
initsh-remove-nodeconfig-gen
branch
from
660411d
to
c07e265
Compare
|
/test |
rgo3
force-pushed
the
initsh-remove-nodeconfig-gen
branch
from
c07e265
to
faf869f
Compare
|
/test |
|
NB: I have removed the |
dylandreimerink
approved these changes
May 21, 2023
pippolo84
approved these changes
May 22, 2023
rgo3
added
the
dont-merge/needs-rebase
rgo3
force-pushed
the
initsh-remove-nodeconfig-gen
branch
from
faf869f
to
2d05a49
Compare
rgo3
removed
the
dont-merge/needs-rebase
This commit moves the generation of node_config.h into Reinitialize(). This is needed for following commits that move node config generation logic from init.sh to Go but depend on other initialization steps happening in Reinitialize(). Signed-off-by: Robin Gögge <r.goegge@isovalent.com>
This refactors writes to node_config.h in init.sh to a Go implementation and centralizes most writes to node_config.h in writeNodeConfigHeader(). Signed-off-by: Robin Gögge <r.goegge@isovalent.com>
rgo3
force-pushed
the
initsh-remove-nodeconfig-gen
branch
from
2d05a49
to
4efde2e
Compare
|
/test |
|
Nice work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors node_config.h generation code in init.sh to Go. In order for this to work properly the function that initially creates node_config.h had to move to Reinitialize().
Fixes: #25378