bpf: nodeport: don't set .addr in revSNAT target #25381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was copy & pasted when splitting the SNAT / revSNAT paths in cilium#20425. But it doesn't make sense for revSNAT - here we only care about the port range in the NAT target, and just match the packet against the available revSNAT entries. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
julianwiedmann
added
sig/datapath
|
/test |
qmonnet
approved these changes
May 11, 2023
|
/test-1.25-4.19 |
|
/test-1.26-net-next Job 'Cilium-PR-K8s-1.26-kernel-net-next' failed: Click to show.Test NameFailure OutputJenkins URL: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.26-kernel-net-next/2239/ If it is a flake and a GitHub issue doesn't already exist to track it, comment Then please upload the Jenkins artifacts to that issue. |
|
Opened #25411 for the |
julianwiedmann
added
the
ready-to-merge
|
One flake, and one jenkins run that actually succeeded but couldn't report back ✔️ due to GH troubles. Marking ready-to-merge - @youngnick could you please press the magic button? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was copy & pasted when splitting the SNAT / revSNAT paths in #20425. But it doesn't make sense for revSNAT - here we only care about the port range in the NAT target, and just match the packet against the available revSNAT entries.