helm: Bump default spire image version #25444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
sayboras
added
the
release-note/minor
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
sayboras
added
area/helm
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
Testing was done locally to make sure there is no breaking change. ``` $ cilium connectivity test --test auth ... [=] Test [echo-ingress-auth-always-fail] ........ [=] Test [echo-ingress-auth-mtls-spiffe] ........ ✅ All 2 tests (16 actions) successful, 45 tests skipped, 0 scenarios skipped. ``` Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras
force-pushed
the
tam/spire-image-helm
branch
from
391b323
to
84fe5fd
Compare
gandro
approved these changes
May 15, 2023
qmonnet
requested changes
May 15, 2023
There was a problem hiding this comment.
Looks good, but please rework the description of the second commit. The motivation is not clear to me (Do you mean that you add this line to the config file to have the bot update the SPIRE images using the info from values.yaml.tmpl, and that unless we add more config this is the only image it should update? If so, please mention explicitly that the intent is to handle updates for the SPIRE images. Or do you mean something else?)
+ Typo in commit title, configu.
This is to make sure that spire images mentnioned in values.yaml.tmpl are updated automatically by renovate bot. While there are other image values, renovate bot should only update spire image values as these are following one liner format. Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras
force-pushed
the
tam/spire-image-helm
branch
from
84fe5fd
to
6dc63c3
Compare
tommyp1ckles
approved these changes
May 15, 2023
qmonnet
approved these changes
May 16, 2023
|
Travis simply had a hiccup: |
|
/test |
|
run-time failed for below issue |
|
/mlh test-runtime |
|
/mlh new-flake Cilium-PR-Runtime-net-next |
|
/test-runtime |
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing was done locally to make sure there is no breaking change.
Signed-off-by: Tam Mach tam.mach@cilium.io