Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix Cilium CLI install in ConformanceKindEnvoyDaemonSet #25459

Merged
merged 1 commit into from May 23, 2023

Conversation

nbusseneau
Copy link
Member

In cef9595 we switched to using a cilium-cli GHA for installing the CLI, but this workflow was merged in main at a later point.

We edit the workflow to be consistent with the other workflows when installing the CLI.

@nbusseneau nbusseneau added area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. labels May 15, 2023
In cef9595 we switched to using a
cilium-cli GHA for installing the CLI, but this workflow was merged in
main at a later point.

We edit the workflow to be consistent with the other workflows when
installing the CLI.

Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
Copy link
Member

@tklauser tklauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@nbusseneau nbusseneau marked this pull request as ready for review May 15, 2023 16:20
@nbusseneau nbusseneau requested review from a team as code owners May 15, 2023 16:20
@nbusseneau nbusseneau requested a review from brlbil May 15, 2023 16:20
@nbusseneau nbusseneau added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 22, 2023
@borkmann borkmann merged commit f748ae3 into cilium:main May 23, 2023
45 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants