Support externalTrafficPolicy=Local for BGP CPlane service VIP advertisement #25477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YutaroHayakawa
added
the
release-note/minor
YutaroHayakawa
force-pushed
the
yutaro/bgp-cplane-etp-local/poc-1
branch
3 times, most recently
from
f9863b5
to
ab6d6b3
Compare
YutaroHayakawa
changed the title
rastislavs
reviewed
May 17, 2023
YutaroHayakawa
force-pushed
the
yutaro/bgp-cplane-etp-local/poc-1
branch
2 times, most recently
from
0743a66
to
e8a5a5c
Compare
YutaroHayakawa
force-pushed
the
yutaro/bgp-cplane-etp-local/poc-1
branch
from
e8a5a5c
to
42d3452
Compare
YutaroHayakawa
force-pushed
the
yutaro/bgp-cplane-etp-local/poc-1
branch
from
42d3452
to
294bbe4
Compare
YutaroHayakawa
force-pushed
the
yutaro/bgp-cplane-etp-local/poc-1
branch
4 times, most recently
from
f766bcd
to
d0b8ffe
Compare
|
/test |
|
Cilium Runtime: Missing the Endpoints resource on the test Hive. I'll fix it. |
YutaroHayakawa
force-pushed
the
yutaro/bgp-cplane-etp-local/poc-1
branch
from
d0b8ffe
to
f00eeee
Compare
|
/test |
|
Cilium L4LB XDP: Hitting complexity issue. Rebasing for pulling the fix (#25892) in. |
The semantics of the externalTrafficPolicy=local for service advertisement. When at least one active endpoint present, we advertise the LB VIP, otherwise, stop advertisement. We can track active endpoints by tracking the Endpoints or EndpointSlice object. They contain the list of the endpoint IPs and nodes. We leverage a new Resource[*Endpoints] for subscribing the changes. For an efficient processing, we wrap it with DiffStore and do reconciliation against the service affected by the endpoint changes. On every reconciliation, we populate the structure called localServices from DiffStore store which represents the information that services have at least one available local endpoint or not. Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
TestLBServiceReconciler is getting longer and now it's hard to follow what's the diff between resources used in tests. Extract resource definition out of the test case definition and deduplicate the fields as much as possible. Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
YutaroHayakawa
force-pushed
the
yutaro/bgp-cplane-etp-local/poc-1
branch
from
f00eeee
to
7e6facb
Compare
|
/test |
|
Cilium Runtime: Timeout while waiting for the image. Retrying... |
|
All green and reviews are in. Ready to merge. |
YutaroHayakawa
added
the
ready-to-merge
mrwulf
added a commit
to mrwulf/home-cluster
that referenced
this pull request
Jun 9, 2023
2 tasks
pchaigno
added
release-note/major
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support
externalTrafficPolicy=localfor BGP CPlane service VIP advertisement. Please see the commit message for more details.You can test this PR in your environment with below lab. Thanks to the recently added
Chart CI Pushworkflow, you don't have to build images.lab.tar.gz