New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Update development setup with preferred kind-based approach #25535
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice - tested on M1 Pro for MacOS, works 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Do you plan to document the config for clusters in this PR?
9195288
to
9996d77
Compare
@qmonnet Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@christarazi 👋🏻
Feel free to re-assign me for review when you're ready! |
Oops @zacharysarah, I've hidden that comment now because it's no longer up-to-date. It's ready for review. 🙂 |
LGTM But I'm clearly biased ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@christarazi Some changes required, otherwise LGTM.
9996d77
to
298524e
Compare
Thanks @zacharysarah! Comments addressed. |
For a long time, we discussed how unreliable / clunky it is to use the Vagrant-based development setup. It is a massive struggle for new contributors as well. Many developers hacked their own scripts to make it work, and even more avoid using it altogether. Many in the community including myself use kind already. It is simply much easier to set up and maintain, without being a drain on your local machine in terms of resources. Let's finally document what many in the community have already been running. Signed-off-by: Chris Tarazi <chris@isovalent.com>
298524e
to
e6cd37e
Compare
Addresses review comments and have other approving reviews already, marking ready to merge. |
For a long time, we discussed how unreliable / clunky it is to use the
Vagrant-based development setup. It is a massive struggle for new
contributors as well.
Many developers hacked their own scripts to make it work, and even more
avoid using it altogether. Many in the community including myself use
kind already. It is simply much easier to set up and maintain, without
being a drain on your local machine in terms of resources.
Let's finally document what many in the community have already been
running.
Signed-off-by: Chris Tarazi chris@isovalent.com