Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable the Hubble before starting with UI via cilium-cli. #25538

Merged
merged 1 commit into from May 31, 2023
Merged

Disable the Hubble before starting with UI via cilium-cli. #25538

merged 1 commit into from May 31, 2023

Conversation

fujitatomoya
Copy link
Contributor

@fujitatomoya fujitatomoya commented May 19, 2023 •
edited by qmonnet

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

Fixes: #24587

docs: Add steps to start Hubble UI with cilium-cli, but only after Hubble itself has started

@fujitatomoya fujitatomoya requested review from a team as code owners May 19, 2023 00:18
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 19, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label May 19, 2023
@fujitatomoya
Copy link
Contributor Author

fujitatomoya commented May 19, 2023 •
edited

address doc section related to #24587, which might lead the user to meet the unexpected failure to start the Hubble UI.

image

@fujitatomoya fujitatomoya force-pushed the doc/20230518-disable-hubble-before-ui branch from a44486a to e39143e Compare May 19, 2023 00:21
@fujitatomoya fujitatomoya mentioned this pull request May 19, 2023
Closed
2 tasks
armenr
armenr suggested changes May 19, 2023
View reviewed changes
Copy link

@armenr armenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looping me in! I've suggested a minor change. Please let me know if you object.

Thank you. 😎✌️

Documentation/gettingstarted/hubble.rst Outdated Show resolved Hide resolved
qmonnet
qmonnet requested changes May 19, 2023
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Minor grammar nits below.

Documentation/gettingstarted/hubble.rst Outdated Show resolved Hide resolved
Documentation/gettingstarted/hubble.rst Outdated Show resolved Hide resolved
@qmonnet
Copy link
Member

qmonnet commented May 19, 2023

Can you please also drop the first, unrelated commit that sneaked in into your PR? I think this is because you initially worked on the master branch, and that commit was merged there by mistake.

@fujitatomoya
add comment to disable the Hubble before starting with UI via cilium-…
de01984 
…cli.

  Fixes: cilium#24587

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya fujitatomoya force-pushed the doc/20230518-disable-hubble-before-ui branch from e39143e to de01984 Compare May 19, 2023 16:07
@fujitatomoya
Copy link
Contributor Author

Can you please also drop the first, unrelated commit that sneaked in into your PR? I think this is because you initially worked on the master branch, and that commit was merged there by mistake.

done in de01984

@fujitatomoya fujitatomoya mentioned this pull request May 19, 2023
Open
@fujitatomoya
Copy link
Contributor Author

Just FYI, created follow-up feature request to cilium-cli, cilium/cilium-cli#1647

qmonnet
qmonnet approved these changes May 23, 2023
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@qmonnet qmonnet added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. labels May 23, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 23, 2023
@qmonnet qmonnet requested a review from armenr May 23, 2023 11:18
@qmonnet
Copy link
Member

qmonnet commented May 30, 2023

Doc change only, no need for the full CI suite.

@qmonnet qmonnet added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 30, 2023
@fujitatomoya
Copy link
Contributor Author

thanks guys for taking the time to review.

btw, do i need to rebase? technically i do not think that is required to do so for this PR, but i can see Merging is blocked though.

@julianwiedmann julianwiedmann merged commit da2185c into cilium:main May 31, 2023
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chancez chancez chancez approved these changes

@tommyp1ckles tommyp1ckles tommyp1ckles approved these changes

@qmonnet qmonnet qmonnet approved these changes

@armenr armenr Awaiting requested review from armenr

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cilium hubble enable --ui fails with services "hubble-peer" already exists
6 participants
@fujitatomoya @qmonnet @chancez @tommyp1ckles @armenr @julianwiedmann