Fix hive test argument order and race #25545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Confusingly, assert.Equal takes 'expected' before 'actual'. Fixing this helps making test errors easier to debug, since there assert explicitly calls out what is 'expected'. Signed-off-by: David Bimmler <david.bimmler@isovalent.com>
Setting the stop timeout to a Millisecond creates a race in the handling of the stop hooks in the lifecycle. Since we check that the stop context is not expired before calling stop hooks, if the Millisecond timeout expires before we run a single stop hook, the `stopped` counter is never incremented. This manifests in the test failing with an actual count of 1, and is easily reproducible by inserting a short sleep before the context Err check in lifecycle.go We're primarily interested in the Start hooks timing out, hence only set the start timeout to be short, and revert the stop timeout to it's default value of a minute. Signed-off-by: David Bimmler <david.bimmler@isovalent.com>
bimmlerd
added
area/CI
|
/test |
|
With Jussis' approval I consider sig-foundations to be covered; removing review request for Lorenz. |
bimmlerd
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor tweaks to hive test to fix argument order to
Equalscalls, and fix a race which could fail tests.