Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINTAINERS: add Dylan Reimerink to the list of maintainers #25577

Merged
merged 1 commit into from May 23, 2023

Conversation

ti-mo
Copy link
Contributor

@ti-mo ti-mo commented May 22, 2023

@dylandreimerink is now a committer. Add to MAINTAINERS.md.

@ti-mo ti-mo requested a review from a team as a code owner May 22, 2023 09:11
@ti-mo ti-mo requested a review from bimmlerd May 22, 2023 09:11
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 22, 2023
@ti-mo ti-mo added the release-note/misc This PR makes changes that have no direct user impact. label May 22, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 22, 2023
@bimmlerd
Copy link
Member

Not a committer myself so not qualified to review this - let's get some maintainer eyes on it.

@bimmlerd bimmlerd requested review from aanm and removed request for bimmlerd May 22, 2023 09:26
@xmulligan
Copy link
Member

@ti-mo can you add the final vote tally in the commit message so we have a public record of it?

@pchaigno
Copy link
Member

Not a committer myself so not qualified to review this - let's get some maintainer eyes on it.

@xmulligan Looks like we may want to fix the CODEOWNERS here.

@xmulligan
Copy link
Member

@pchaigno I've created #25578 for this

Voting results:
YES: 32 (70%)
NO: 0 (0%)
ABSTAIN: 14 (30%)

With the Company Block Vote Limit applied:
YES: (30 / (30/6)) + 2 = 8 votes
NO: 0 votes

Signed-off-by: Timo Beckers <timo@isovalent.com>
@ti-mo
Copy link
Contributor Author

ti-mo commented May 22, 2023

@ti-mo can you add the final vote tally in the commit message so we have a public record of it?

@xmulligan Sure, done.

Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@pchaigno pchaigno added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 22, 2023
@joestringer joestringer merged commit f5db9ca into cilium:main May 23, 2023
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants