Controller clean up #25579
Merged
Controller clean up #25579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
|
/test |
|
Hey, are you aware of |
jrajahalme
added
release-note/misc
|
@joamaki Was not aware of |
jrajahalme
force-pushed
the
controller-clean-up
branch
from
2cb0893
to
8240fc9
Compare
pippolo84
approved these changes
May 29, 2023
pkg/controller/manager.go
Outdated
| ) | ||
|
|
||
| var ( | ||
| // globalStatus is the global status of all controllers | ||
| globalStatus = NewManager() | ||
| ) | ||
|
|
||
| type controllerMap map[string]*Controller | ||
| type managedController struct { |
There was a problem hiding this comment.
Nit: I think it's better to move unexported types to the bottom, after the exported ones, in order to improve readability for the package users.
|
Current CI failures should be solved simply rebasing. |
Simplify controller goroutine implementation by using an infinite interval instead of a series of 10 minute intervals when the controller function does not need to run. Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
Make the contract between the manager and a controller more explicit by documenting it in controller struct definition. Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
ControllerParams is passed by value, so it is possible to add cancel to the given context, to define it if nil. Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
Pass ControllerParameter updates in the update channel to simplify code. We already have the channel for update notifications, migth as well use it to pass the updated parameters to simplify synchronization between the manager and the controller. Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
…ntract Move controller fields only accessed by the manager to a new 'managedController' type. This hides these fields from the 'controller' type making documentation easier. Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
TerminationChannel function was only used for testing, move it to test file. Signed-off-by: Jarno Rajahalme <jarno@isovalent.com> info: patch template saved to `-`
Controller type need not be exported. Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
jrajahalme
force-pushed
the
controller-clean-up
branch
from
8240fc9
to
3124bda
Compare
|
Rebased for CI fixes. |
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up internals of
pkg/controllerby: