Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helm: Improve spire template #25589

Merged
merged 2 commits into from May 26, 2023
Merged

helm: Improve spire template #25589

merged 2 commits into from May 26, 2023

Conversation

sayboras
Copy link
Member

@sayboras sayboras commented May 22, 2023 •
edited

Please refer to individual commit for more details.

Fixes: #24552

@sayboras
helm: Update the spire agent health check port
801eb17 
This commit is to update spire agent health check port from common value
(e.g. 8080) to 4251. Also, as spire agent is running in host network, we
should update the system requirement docs as well.

Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras
helm: Update the spire server DNS
7e687e1 
Having local domain seems to add no value at all, better just remove it.

Suggested-by: André Martins <andre@cilium.io>
Signed-off-by: Tam Mach <tam.mach@cilium.io>
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 22, 2023
@sayboras sayboras added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label May 22, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 22, 2023
@sayboras sayboras added area/helm Impacts helm charts and user deployment experience dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. area/servicemesh GH issues or PRs regarding servicemesh labels May 22, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 22, 2023
@sayboras sayboras marked this pull request as ready for review May 23, 2023 06:08
@sayboras sayboras requested review from a team as code owners May 23, 2023 06:08
zacharysarah
zacharysarah approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@zacharysarah zacharysarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from a docs perspective

@sayboras
Copy link
Member Author

sayboras commented May 23, 2023 •
edited by maintainer-s-little-helper bot

/test

Job 'Cilium-PR-K8s-1.26-kernel-net-next' failed:

Click to show.

Test Name

K8sDatapathConfig High-scale IPcache Test ingress policy enforcement

Failure Output

FAIL: Expected command: kubectl exec -n kube-system cilium-6cpmw -- bpftool map update pinned /sys/fs/bpf/tc/globals/cilium_world_cidrs4 key 0 0 0 0 0 0 0 0 value 1

Jenkins URL: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.26-kernel-net-next/86/

If it is a flake and a GitHub issue doesn't already exist to track it, comment /mlh new-flake Cilium-PR-K8s-1.26-kernel-net-next so I can create one.

Then please upload the Jenkins artifacts to that issue.

@sayboras
Copy link
Member Author

/test-runtime

@sayboras
Copy link
Member Author

/test-1.26-net-next

@sayboras sayboras mentioned this pull request May 24, 2023
Closed
@sayboras
Copy link
Member Author

/test-runtime

@sayboras
Copy link
Member Author

test-1.26-net-next failures due to the below issues:

All other jobs are ✔️ , just waiting for required review.

@sayboras
Copy link
Member Author

/test-1.26-net-next

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 26, 2023
@sayboras sayboras merged commit 71b9e2e into cilium:main May 26, 2023
59 checks passed
@sayboras sayboras deleted the tam/helm-spire branch May 26, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaworu kaworu kaworu approved these changes

@joamaki joamaki joamaki approved these changes

@zacharysarah zacharysarah zacharysarah approved these changes

Assignees
No one assigned
Labels
area/helm Impacts helm charts and user deployment experience area/servicemesh GH issues or PRs regarding servicemesh ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ensure mutual auth and Policy interact in safe ways
4 participants
@sayboras @kaworu @joamaki @zacharysarah