Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaces K8s NewDeltaFIFO with NewDeltaFIFOWithOptions #25606

Merged
merged 1 commit into from Jun 6, 2023
Merged

Replaces K8s NewDeltaFIFO with NewDeltaFIFOWithOptions #25606

merged 1 commit into from Jun 6, 2023

Conversation

danehans
Copy link
Contributor

Replaces NewDeltaFIFO() in the k8s pkg with NewDeltaFIFOWithOptions().

Fixes: #25596

@danehans
Replaces K8s NewDeltaFIFO with NewDeltaFIFOWithOptions
003808e 
Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io>
@danehans danehans requested a review from a team as a code owner May 22, 2023 22:59
@danehans danehans requested a review from joamaki May 22, 2023 22:59
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 22, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label May 22, 2023
@joamaki joamaki added the release-note/misc This PR makes changes that have no direct user impact. label May 23, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 23, 2023
@joamaki
Copy link
Contributor

joamaki commented May 23, 2023

/test

@danehans
Copy link
Contributor Author

danehans commented May 23, 2023 •
edited

cc: @christarazi @squeed

@christarazi
Copy link
Member

/test-vagrant

@christarazi christarazi added the sig/k8s Impacts the kubernetes API, or kubernetes -> cilium internals translation layers. label May 23, 2023
@danehans
Copy link
Contributor Author

@christarazi all CI jobs are passing. Let me know if anything else is needed for this PR to get tagged.

@danehans
Copy link
Contributor Author

@joamaki PTAL when you have a moment.

@danehans
Copy link
Contributor Author

@joamaki this should be a pretty quick review. Do you have time to take a look this week? If not, can you suggest others that can help?

@danehans
Copy link
Contributor Author

danehans commented Jun 2, 2023

@christarazi when you have a moment, do you mind reviewing or assigning another maintainer to review?

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 6, 2023
@dylandreimerink dylandreimerink merged commit 5e96115 into cilium:main Jun 6, 2023
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joamaki joamaki joamaki approved these changes

Assignees
No one assigned
Labels
kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/k8s Impacts the kubernetes API, or kubernetes -> cilium internals translation layers.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CFP: NewDeltaFIFO in the informer pkg is Deprecated
4 participants
@danehans @joamaki @christarazi @dylandreimerink