daemon: Update code comment regarding PolicyReactionEvent #25607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code comment is confusing because it states that reactToRuleUpdates() waits until all endpoints have been regenerated. Upon code inspection, this is incorrect and not necessary either. It is not necessary because 2820a1f ("daemon: Switch policy over to new IPCache interface") fixed the previously buggy behavior where prefixes were pushed into the ipcache BPF map before the policy recalculation (i.e. endpoint regeneration) has completed (endpoint policymap entries). This buggy behavior likely caused CI flakes of some sort when new policies were added. The 8f20d3b commit mistakenly asserted this, so fix it in this commit. Fixes: 8f20d3b ("daemon: Postpone ipcache upserts until after policy changes have been regenerated by endpoints.") Reported-by: Joe Stringer <joe@cilium.io> Signed-off-by: Chris Tarazi <chris@isovalent.com>
christarazi
added
kind/cleanup
maintainer-s-little-helper
bot
added
dont-merge/needs-release-note-label
|
/test |
nebril
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code comment is confusing because it states that
reactToRuleUpdates() waits until all endpoints have been regenerated.
Upon code inspection, this is incorrect and not necessary either. It is
not necessary because 2820a1f ("daemon: Switch policy over to new
IPCache interface") fixed the previously buggy behavior where prefixes
were pushed into the ipcache BPF map before the policy recalculation
(i.e. endpoint regeneration) has completed (endpoint policymap entries).
This buggy behavior likely caused CI flakes of some sort when new
policies were added.
The 8f20d3b commit mistakenly asserted this, so fix it in this
commit.
Fixes: 8f20d3b ("daemon: Postpone ipcache upserts until after policy
changes have been regenerated by endpoints.")
Reported-by: Joe Stringer joe@cilium.io
Signed-off-by: Chris Tarazi chris@isovalent.com