Use CLI-based Helm installation for ingress tests #25609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
github-actions
bot
added
the
kind/community-contribution
15 tasks
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
dhawton
force-pushed
the
dhawton/helm-conformance-ingress
branch
from
1d3434f
to
3898fca
Compare
dhawton
force-pushed
the
dhawton/helm-conformance-ingress
branch
from
3898fca
to
242e44c
Compare
sayboras
requested changes
May 23, 2023
dhawton
force-pushed
the
dhawton/helm-conformance-ingress
branch
from
242e44c
to
f50f2d7
Compare
dhawton
force-pushed
the
dhawton/helm-conformance-ingress
branch
from
f50f2d7
to
0e16fdb
Compare
|
Commit 0e16fdb9a0362cf62cd53156ea1992df18dbacf8 does not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
maintainer-s-little-helper
bot
added
the
dont-merge/needs-sign-off
Signed-off-by: Daniel Hawton <daniel.hawton@solo.io>
dhawton
force-pushed
the
dhawton/helm-conformance-ingress
branch
from
0e16fdb
to
8c26829
Compare
|
Commit 0e16fdb9a0362cf62cd53156ea1992df18dbacf8 does not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
aanm
removed
the
dont-merge/needs-sign-off
bimmlerd
approved these changes
May 23, 2023
zacharysarah
approved these changes
May 23, 2023
brlbil
approved these changes
May 23, 2023
|
The changes are limited to gha Conformance Ingress, which is passed in this PR. All reviews are in, marking this ready to merge. Thanks a lot for your contribution 🎖️ |
sayboras
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
conformance-ingressworkflow to cli-based helm install mode in an effort to complete another item in #25156Locally act wasn't cooperating so may need CI to troubleshoot any potential issues.