Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace the string with constants from the http package #25614

Merged
merged 1 commit into from May 24, 2023
Merged

Replace the string with constants from the http package #25614

merged 1 commit into from May 24, 2023

Conversation

Fish-pro
Copy link
Contributor

Signed-off-by: Fish-pro zechun.chen@daocloud.io

@Fish-pro Fish-pro requested review from a team as code owners May 23, 2023 08:20
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 23, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label May 23, 2023
@Fish-pro Fish-pro force-pushed the chore/httpconst branch 3 times, most recently from 39924ab to 0e9285e Compare May 23, 2023 08:28
@Fish-pro
Copy link
Contributor Author

The main branch merges frequently, resulting in need update branch?

@Fish-pro
Copy link
Contributor Author

image Why is the document checked without modification? Why

@mhofstetter mhofstetter added the release-note/misc This PR makes changes that have no direct user impact. label May 23, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 23, 2023
@mhofstetter
Copy link
Member

thanks for your contribution @Fish-pro

The main branch merges frequently, resulting in need update branch?

no need to update the branch on every merge in main - except you would face some conflicts or issues with CI.

Why is the document checked without modification? Why

custom-vet checks the whole project within the check Go-related checks / precheck. looks like you picked up an issue which landed in main when rebasing. #25615 fixes this. this PR needs another rebase once the fix has been merged.

@Fish-pro
Copy link
Contributor Author

Fish-pro commented May 23, 2023 •
edited

thanks for your contribution @Fish-pro

The main branch merges frequently, resulting in need update branch?

no need to update the branch on every merge in main - except you would face some conflicts or issues with CI.

Why is the document checked without modification? Why

custom-vet checks the whole project within the check Go-related checks / precheck. looks like you picked up an issue which landed in main when rebasing. #25615 fixes this. this PR needs another rebase once the fix has been merged.

@mhofstetter Thanks, I got it

@mhofstetter
Copy link
Member

/test

@christarazi
Copy link
Member

/test-vagrant

@Fish-pro
Replace the string with constants from the http package
50f24fd 
Signed-off-by: Zechun Chen <zechun.chen@daocloud.io>
@mhofstetter
Copy link
Member

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 24, 2023
@squeed squeed merged commit e9a2805 into cilium:main May 24, 2023
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jschwinger233 jschwinger233 jschwinger233 approved these changes

@mhofstetter mhofstetter mhofstetter approved these changes

Assignees
No one assigned
Labels
kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Fish-pro @mhofstetter @christarazi @jschwinger233 @squeed