Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hubble: replace deprecated usage of grpc.WithInsecure. #25631

Merged
merged 1 commit into from Aug 10, 2023
Merged

hubble: replace deprecated usage of grpc.WithInsecure. #25631

merged 1 commit into from Aug 10, 2023

Conversation

tommyp1ckles
Copy link
Contributor

@tommyp1ckles tommyp1ckles commented May 23, 2023 •
edited

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 23, 2023
@tommyp1ckles tommyp1ckles added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label May 23, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 23, 2023
@tommyp1ckles tommyp1ckles requested a review from rolinh May 23, 2023 21:51
@tommyp1ckles tommyp1ckles force-pushed the pr/tp/remove-deprecated-withinsecure-usage branch from 419f485 to 5d15fcf Compare May 23, 2023 21:51
@tommyp1ckles tommyp1ckles marked this pull request as ready for review May 23, 2023 21:51
@tommyp1ckles tommyp1ckles requested a review from a team as a code owner May 23, 2023 21:51
@tommyp1ckles
Copy link
Contributor Author

/test

rolinh
rolinh approved these changes May 24, 2023
View reviewed changes
Copy link
Member

@rolinh rolinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tommyp1ckles
Copy link
Contributor Author

/test-runtime

@tommyp1ckles
Copy link
Contributor Author

/test-1.26-net-next

@tommyp1ckles tommyp1ckles force-pushed the pr/tp/remove-deprecated-withinsecure-usage branch from 5d15fcf to b6df21a Compare June 13, 2023 18:29
@tommyp1ckles
Copy link
Contributor Author

/test-1.26-net-next

@tommyp1ckles
Copy link
Contributor Author

/test

@tommyp1ckles tommyp1ckles added the sig/hubble Impacts hubble server or relay label Jun 13, 2023
@tommyp1ckles
Copy link
Contributor Author

/test

@tommyp1ckles tommyp1ckles force-pushed the pr/tp/remove-deprecated-withinsecure-usage branch from b6df21a to f908021 Compare June 30, 2023 18:38
@github-actions
Copy link

This pull request has been automatically marked as stale because it
has not had recent activity. It will be closed if no further activity
occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Jul 31, 2023
@tommyp1ckles
hubble: replace deprecated usage of grpc.WithInsecure.
e889847 
Current method is to use `grpc.WithTransportCredentials(insecure.NewCredentials())`

Signed-off-by: Tom Hadlaw <tom.hadlaw@isovalent.com>
@tommyp1ckles tommyp1ckles force-pushed the pr/tp/remove-deprecated-withinsecure-usage branch from f908021 to e889847 Compare August 10, 2023 04:39
@tommyp1ckles
Copy link
Contributor Author

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Aug 10, 2023
@chancez
Copy link
Contributor

chancez commented Aug 10, 2023

Merging now since it's a trivial fix and CI is finally passing.

@chancez chancez merged commit dc44cd7 into main Aug 10, 2023
196 checks passed
@chancez chancez deleted the pr/tp/remove-deprecated-withinsecure-usage branch August 10, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolinh rolinh rolinh approved these changes

@chancez chancez chancez approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium. sig/hubble Impacts hubble server or relay stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tommyp1ckles @chancez @rolinh