auth: auth map cache #25634
Merged
auth: auth map cache #25634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhofstetter
added
release-note/misc
With the replacement of the contrack map with the auth map, the authenticator interface is no longer necessary. Therefore, this commit reuses the interface for an internal abstraction of the auth map itself - which will be reused in the cache implementation. The new interface and its types are moved from the manager to its own file `authmap.go`. Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
mhofstetter
force-pushed
the
pr/mhofstetter/authmap-cache
branch
from
2ace740
to
107166d
Compare
This commit introduces a caching layer for the auth map. The intention of the cache is to be used as replacement for the auth writer itself and acts as an write/read-through cache. At startup, the cache gets restored with entries from the BPF map. Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
mhofstetter
force-pushed
the
pr/mhofstetter/authmap-cache
branch
from
107166d
to
6de0440
Compare
|
changed the order of lifecycle hook registration - so the cache gets restored before starting the manager |
meyskens
approved these changes
May 26, 2023
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for the auth map garbage collection (#25213), this PR adds a caching layer for the auth map.
auth: rename authenticator to internal authmap abstraction
With the replacement of the contrack map with the auth map, the authenticator interface is no longer necessary.
Therefore, this commit reuses and refactores the interface for an internal abstraction of the auth map itself - which will be reused in the cache implementation.
The new interface and its types are moved from the manager to its own file
authmap.go.auth: auth map cache implementation
This commit introduces a caching layer for the auth map.
The intention of the cache is to be used as replacement for the auth writer itself and acts as an write/read-through cache.
At startup, the cache gets restored with entries from the BPF map.