Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci-e2e: Bump cilium-cli v0.1.4.5 #25672

Merged
merged 2 commits into from May 30, 2023
Merged

ci-e2e: Bump cilium-cli v0.1.4.5 #25672

merged 2 commits into from May 30, 2023

Conversation

brb
Copy link
Member

@brb brb commented May 25, 2023

This allows us to drop the external-from-cidrs detection, and also drop the "--datapath" connectivity test, as it was merged into the main connectivity suite. Both were done in [1].

[1]: cilium/cilium-cli#1579

ci-e2e success - https://github.com/cilium/cilium/actions/runs/5092181640/jobs/9153207931?pr=25673
ci-e2e-v1.13 success - https://github.com/cilium/cilium/actions/runs/5092181640/jobs/9153207931?pr=25673

@brb brb added area/CI-improvement Topic or proposal to improve the Continuous Integration workflow release-note/ci This PR makes changes to the CI. labels May 25, 2023
@brb brb force-pushed the pr/brb/ci-update-cli-0.14.4 branch from 8d2c721 to e910782 Compare May 25, 2023 15:46
brb added 2 commits May 26, 2023 16:53
This allows us to drop the external-from-cidrs detection, and also drop
the "--datapath" connectivity test, as it was merged into the main
connectivity suite. Both were done in [1].

[1]: cilium/cilium-cli#1579

Signed-off-by: Martynas Pumputis <m@lambda.lt>
[1] has fixed skipping some tests which previously was failing on v1.13.

[1]: cilium/cilium-cli#1579

Signed-off-by: Martynas Pumputis <m@lambda.lt>
@brb brb force-pushed the pr/brb/ci-update-cli-0.14.4 branch from e910782 to 0064fe2 Compare May 26, 2023 14:54
@brb brb changed the title ci-e2e: Bump cilium-cli v0.1.4.4 ci-e2e: Bump cilium-cli v0.1.4.5 May 26, 2023
@brb brb force-pushed the pr/brb/ci-update-cli-0.14.4 branch from 0064fe2 to 0a80f13 Compare May 26, 2023 15:58
@brb brb marked this pull request as ready for review May 26, 2023 15:58
@brb brb requested review from a team as code owners May 26, 2023 15:58
@nbusseneau
Copy link
Member

Less code = more yes.

@brb brb requested a review from joestringer May 26, 2023 16:27
Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@brb brb added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 30, 2023
@brb brb merged commit 04fbe44 into main May 30, 2023
45 checks passed
@brb brb deleted the pr/brb/ci-update-cli-0.14.4 branch May 30, 2023 07:07
@julianwiedmann
Copy link
Member

I assume renovate would also have done this for us automatically (#25700) ? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI-improvement Topic or proposal to improve the Continuous Integration workflow ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants