New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci-e2e: Bump cilium-cli v0.1.4.5 #25672
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brb
added
area/CI-improvement
Topic or proposal to improve the Continuous Integration workflow
release-note/ci
This PR makes changes to the CI.
labels
May 25, 2023
brb
force-pushed
the
pr/brb/ci-update-cli-0.14.4
branch
from
May 25, 2023 15:46
8d2c721
to
e910782
Compare
This allows us to drop the external-from-cidrs detection, and also drop the "--datapath" connectivity test, as it was merged into the main connectivity suite. Both were done in [1]. [1]: cilium/cilium-cli#1579 Signed-off-by: Martynas Pumputis <m@lambda.lt>
[1] has fixed skipping some tests which previously was failing on v1.13. [1]: cilium/cilium-cli#1579 Signed-off-by: Martynas Pumputis <m@lambda.lt>
brb
force-pushed
the
pr/brb/ci-update-cli-0.14.4
branch
from
May 26, 2023 14:54
e910782
to
0064fe2
Compare
brb
changed the title
ci-e2e: Bump cilium-cli v0.1.4.4
ci-e2e: Bump cilium-cli v0.1.4.5
May 26, 2023
brb
force-pushed
the
pr/brb/ci-update-cli-0.14.4
branch
from
May 26, 2023 15:58
0064fe2
to
0a80f13
Compare
nbusseneau
approved these changes
May 26, 2023
Less code = more yes. |
joestringer
reviewed
May 26, 2023
jibi
approved these changes
May 26, 2023
joestringer
approved these changes
May 26, 2023
aanm
approved these changes
May 26, 2023
sayboras
approved these changes
May 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
viktor-kurchenko
approved these changes
May 29, 2023
brb
added
the
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
label
May 30, 2023
I assume renovate would also have done this for us automatically (#25700) ? 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/CI-improvement
Topic or proposal to improve the Continuous Integration workflow
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
release-note/ci
This PR makes changes to the CI.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to drop the external-from-cidrs detection, and also drop the "--datapath" connectivity test, as it was merged into the main connectivity suite. Both were done in [1].
[1]: cilium/cilium-cli#1579
ci-e2e success - https://github.com/cilium/cilium/actions/runs/5092181640/jobs/9153207931?pr=25673
ci-e2e-v1.13 success - https://github.com/cilium/cilium/actions/runs/5092181640/jobs/9153207931?pr=25673