testutils: remove gocheck #25684
Merged
testutils: remove gocheck #25684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmb
added
area/CI
|
/test |
|
/test |
|
/test |
|
/test |
|
ci-l4lb is #25892 |
giorio94
approved these changes
Jun 5, 2023
There was a problem hiding this comment.
Nit. Should these changes be in a separate commit?
There was a problem hiding this comment.
You mean, split removing checkmate from testutils from removing IntegrationCheck?
There was a problem hiding this comment.
Yep, exactly (if that makes sense to you)
nebril
approved these changes
Jun 6, 2023
|
@tommyp1ckles could you give this PR a quick one over please? |
lmb
force-pushed
the
testutils-no-gocheck
branch
from
7b68378
to
7e01406
Compare
|
/test |
|
Both CI failures are known flakes. |
lmb
force-pushed
the
testutils-no-gocheck
branch
from
7e01406
to
aef811d
Compare
|
/test Job 'Cilium-PR-K8s-1.26-kernel-net-next' hit: #25958 (89.13% similarity) |
|
ci-ginkgo is #26009 |
|
test-1.26-net-next hits #25958 |
|
/test-1.26-net-next |
|
/test-ci-ginkgo |
gocheck tests can now call IntegrationTest, migrate them and remove IntegrationCheck. Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
Remove uses of gocheck in favour of testing. Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
lmb
force-pushed
the
testutils-no-gocheck
branch
from
aef811d
to
2e1f05f
Compare
|
/test |
aanm
approved these changes
Jun 14, 2023
|
runtime is #26222 |
lmb
added
the
ready-to-merge
tommyp1ckles
approved these changes
Jun 15, 2023
|
sorry for the delay - looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use testing instead of gopkg.in/check.v1. Migrate users of IntegrationCheck to IntegrationTest.