Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bgpv1: Fixes godoc bugs #25686

Merged
merged 1 commit into from May 29, 2023
Merged

bgpv1: Fixes godoc bugs #25686

merged 1 commit into from May 29, 2023

Conversation

danehans
Copy link
Contributor

@danehans danehans commented May 25, 2023 •
edited by dylandreimerink

  • Updates the BGPRouterManager type godoc to reference the correct pkg name of the BGPRouterManager interface.
  • Updates the NewBGPRouterManager() func godoc to reference BGPRouterManager for details.
Godoc improvements for `pkg/bgpv1`

@danehans
bgpv1: Fixes godoc bugs
37f75d7 
Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io>
@danehans danehans requested a review from a team as a code owner May 25, 2023 16:54
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 25, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label May 25, 2023
dylandreimerink
dylandreimerink approved these changes May 26, 2023
View reviewed changes
Copy link
Member

@dylandreimerink dylandreimerink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the improvements!

@dylandreimerink dylandreimerink added the release-note/misc This PR makes changes that have no direct user impact. label May 26, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 26, 2023
@dylandreimerink
Copy link
Member

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 26, 2023
@julianwiedmann julianwiedmann merged commit d94e863 into cilium:main May 29, 2023
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylandreimerink dylandreimerink dylandreimerink approved these changes

Assignees
No one assigned
Labels
kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danehans @dylandreimerink @julianwiedmann