Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helm: add extraArgs to clustermesh-apiserver #25693

Merged
merged 1 commit into from Jun 5, 2023
Merged

helm: add extraArgs to clustermesh-apiserver #25693

merged 1 commit into from Jun 5, 2023

Conversation

rcanderson23
Copy link
Contributor

@rcanderson23 rcanderson23 commented May 25, 2023 •
edited

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

This adds extraArgs to clustermesh-apiserver in the helm chart. This will allow users to increase kvstore-opt such as etcd.qps which can't be overriden via env variables since args take precedence.

helm: add extraArgs to clustermesh-apiserver

@rcanderson23 rcanderson23 requested review from a team as code owners May 25, 2023 22:04
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 25, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label May 25, 2023
@kaworu kaworu requested review from a team and giorio94 and removed request for a team May 26, 2023 10:03
@kaworu kaworu added kind/feature This introduces new functionality. area/clustermesh Relates to multi-cluster routing functionality in Cilium. release-note/misc This PR makes changes that have no direct user impact. area/helm Impacts helm charts and user deployment experience labels May 26, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 26, 2023
kaworu
kaworu approved these changes May 26, 2023
View reviewed changes
Copy link
Member

@kaworu kaworu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @rcanderson23, Helm changes LGTM, bringing in @cilium/sig-clustermesh to the review.

giorio94
giorio94 reviewed May 26, 2023
View reviewed changes
Copy link
Member

@giorio94 giorio94 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rcanderson23! Changes look good to me.
You should run the following commands to update the auto-generated files:

make -C install/kubernetes
make -C Documentation update-helm-values

@rcanderson23 rcanderson23 mentioned this pull request May 26, 2023
Closed
@giorio94 giorio94 self-requested a review May 26, 2023 17:03
@giorio94
Copy link
Member

giorio94 commented May 29, 2023 •
edited

It seems that the linter is not yet happy. @rcanderson23 Could you please rerun again make -C install/kubernetes? Feel free to squash all commits in a single one.

@giorio94
Copy link
Member

giorio94 commented May 30, 2023 •
edited by maintainer-s-little-helper bot

/test

Job 'Cilium-PR-K8s-1.26-kernel-net-next' failed:

Click to show.

Test Name

K8sUpdates Tests upgrade and downgrade from a Cilium stable image to master

Failure Output

FAIL: Unexpected missed tail calls

Jenkins URL: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.26-kernel-net-next/292/

If it is a flake and a GitHub issue doesn't already exist to track it, comment /mlh new-flake Cilium-PR-K8s-1.26-kernel-net-next so I can create one.

Then please upload the Jenkins artifacts to that issue.

@giorio94
Copy link
Member

Cilium L4LB XDP hit #25663. Rerunning

@giorio94
Copy link
Member

giorio94 commented Jun 1, 2023 •
edited by maintainer-s-little-helper bot

/test-1.26-net-next

Hit #24514

Job 'Cilium-PR-K8s-1.26-kernel-net-next' failed:

Click to show.

Test Name

K8sDatapathServicesTest Checks N/S loadbalancing Tests with XDP, direct routing, DSR with Geneve and Maglev

Failure Output

FAIL: Can not connect to service "http://[fd04::11]:30175" from outside cluster (2/10)

Jenkins URL: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.26-kernel-net-next/355/

If it is a flake and a GitHub issue doesn't already exist to track it, comment /mlh new-flake Cilium-PR-K8s-1.26-kernel-net-next so I can create one.

Then please upload the Jenkins artifacts to that issue.

@giorio94
Copy link
Member

giorio94 commented Jun 1, 2023

Cilium Runtime is failing because the PR is not up-to-date with main, but these tests are not required at the moment.

@giorio94
Copy link
Member

giorio94 commented Jun 1, 2023 •
edited

/test-1.26-net-next

Hit unrelated failure: #22579 The failure was due to https://cilium.slack.com/archives/C7PE7V806/p1685553432805279

Job 'Cilium-PR-K8s-1.26-kernel-net-next' failed:

Click to show.

Test Name

K8sDatapathServicesTest Checks N/S loadbalancing Tests with XDP, direct routing, DSR with Geneve and Maglev

Failure Output

FAIL: Can not connect to service "http://[fd04::11]:30877" from outside cluster (1/10)

Jenkins URL: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.26-kernel-net-next/375/

If it is a flake and a GitHub issue doesn't already exist to track it, comment /mlh new-flake Cilium-PR-K8s-1.26-kernel-net-next so I can create one.

Then please upload the Jenkins artifacts to that issue.

@giorio94
Copy link
Member

giorio94 commented Jun 1, 2023

@rcanderson23 Could you please rebase onto main to pick the latest changes and make the CI happy?

@rcanderson23
helm: add extraArgs to clustermesh-apiserver
4387b2f 
This allows the ability supply extra arguments to clustermesh-apiserver.
It is currently not possible to supply other kvstore-opts via env
variables due higher precedence given to arguments.

Signed-off-by: Carson Anderson <carson.anderson@goteleport.com>
@giorio94
Copy link
Member

giorio94 commented Jun 1, 2023

/test

@giorio94
Copy link
Member

giorio94 commented Jun 5, 2023 •
edited

/test-runtime

Hit known flake: #25291

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 5, 2023
@dylandreimerink dylandreimerink merged commit a899cf0 into cilium:main Jun 5, 2023
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaworu kaworu kaworu approved these changes

@youngnick youngnick youngnick approved these changes

@giorio94 giorio94 giorio94 approved these changes

Assignees
No one assigned
Labels
area/clustermesh Relates to multi-cluster routing functionality in Cilium. area/helm Impacts helm charts and user deployment experience kind/community-contribution This was a contribution made by a community member. kind/feature This introduces new functionality. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rcanderson23 @giorio94 @kaworu @youngnick @dylandreimerink