Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Slack updates #25723

Merged
merged 1 commit into from Jun 6, 2023
Merged

docs: Slack updates #25723

merged 1 commit into from Jun 6, 2023

Conversation

lizrice
Copy link
Member

@lizrice lizrice commented May 26, 2023

Changes to the Slack docs page:

  • List some more of the existing Slack channels
  • Clarify that not all Slack channels have to be listed in the docs
  • Document how to request a new Slack channel

Note: I've suggested that for simply creating a Slack channel this issue could be filed in the cilium/community repo. There is a very similar process for creating a SIG, which gets a Slack channel and regular Zoom meeting, and currently is requested via an issue in cilium/cilium. Should we move that to cilium/community as well?

@lizrice lizrice requested a review from a team as a code owner May 26, 2023 17:38
@lizrice lizrice requested a review from bimmlerd May 26, 2023 17:38
@maintainer-s-little-helper
Copy link

Commit 69a76d30c7efba7b0c9f1e59a07cd3478f5a5182 does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels May 26, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label May 26, 2023
bimmlerd
bimmlerd requested changes May 30, 2023
View reviewed changes
Documentation/community/community.rst Outdated Show resolved Hide resolved
@bimmlerd bimmlerd added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. labels May 30, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 30, 2023
@maintainer-s-little-helper
Copy link

Commit 914c7fdf2b516547724aaedb0b56e8dfa446d420 does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label May 30, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label May 30, 2023
bimmlerd
bimmlerd requested changes May 31, 2023
View reviewed changes
Copy link
Member

@bimmlerd bimmlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😞 Now the spell checker is giving you grief.


Please fix the following spelling mistakes:
* Documentation/community/community.rst:45: (tetragon)  #tetragon
* Documentation/community/community.rst:83: (ciliumcon)  #ciliumcon
* Documentation/community/community.rst:84: (ctf)  #ctf

If the words are not misspelled, run:
Documentation/update-spelling_wordlist.sh ciliumcon ctf tetragon

Do let me know if you want me to push this over the finish line :-)

@lizrice lizrice requested a review from a team as a code owner June 1, 2023 11:24
@lizrice lizrice requested a review from qmonnet June 1, 2023 11:24
qmonnet
qmonnet reviewed Jun 1, 2023
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please clean-up the description of your first commit, it contains two titles and two identical Signed-off-by.

@qmonnet qmonnet requested a review from bimmlerd June 1, 2023 11:33
bimmlerd
bimmlerd approved these changes Jun 2, 2023
View reviewed changes
Copy link
Member

@bimmlerd bimmlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes lgtm now- thanks!
Commitwise, best to squash the two commits, as well as address Quentin's comment about the commit message.

@lizrice @bimmlerd
docs: Slack updates
494a5c1 
List some more of the existing Slack channels
Clarify that not all Slack channels have to be listed in the docs
Document how to request a new Slack channel

Signed-off-by: Liz Rice <liz@lizrice.com>
Co-authored-by: David Bimmler <david.bimmler@isovalent.com>
sayboras
sayboras reviewed Jun 2, 2023
View reviewed changes
Documentation/community/community.rst
@@ -41,6 +41,8 @@ Name Purpose
#kubernetes Kubernetes-specific questions
#networkpolicy Questions on network policies
#release Release announcements only
#service-mesh Questions on Cilium Service Mesh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a lot of community members ares using this slack channel for clustermesh as well, seems like we don't have dedicated channel for clustermesh.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you be more explicit please, is this an request for creating the channel and adding to the list in this PR? Or are you OK with the current update?
@lizrice: Have you considered creating #clustermesh?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, it will be great to have a dedicated clustermesh channel 👍, the changes in this PR look good to me.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK thanks! Now with this PR, I guess you know what to do to request the channel creation 😁

@qmonnet
Copy link
Member

qmonnet commented Jun 6, 2023

Doc change only, documentation workflow and Netlify preview passed. This is good to go

@qmonnet qmonnet added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 6, 2023
@dylandreimerink dylandreimerink merged commit c2b5e70 into main Jun 6, 2023
36 checks passed
@dylandreimerink dylandreimerink deleted the pr/lizrice/create-slack branch June 6, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sayboras sayboras sayboras left review comments

@qmonnet qmonnet qmonnet approved these changes

@bimmlerd bimmlerd bimmlerd approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lizrice @qmonnet @bimmlerd @sayboras @dylandreimerink