bpf: nat: tolerate unhandled protocol types in revSNAT path #25740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the past we would just pass up packets with unknown protocols, and let the next layer (or the stack) deal with them. cilium#19753 recently added error handling for the revSNAT paths, so that we can catch errors while eg. rewriting the packet headers. But we want to preserve the old behaviour of tolerating unknown protocol types. So return NAT_PUNT_TO_STACK from a few additional ICMP paths. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
julianwiedmann
added
sig/datapath
|
/test Job 'Cilium-PR-K8s-1.25-kernel-4.19' failed: Click to show.Test NameFailure OutputJenkins URL: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.25-kernel-4.19/208/ If it is a flake and a GitHub issue doesn't already exist to track it, comment Then please upload the Jenkins artifacts to that issue. |
gentoo-root
approved these changes
May 29, 2023
|
/test-1.25-4.19 |
maintainer-s-little-helper
bot
added
the
ready-to-merge
|
@julianwiedmann Too late to the party, but do you plan to do the same for |
We should make the same change, but not sure whether I will get to it. It's also not quite as trivial (as we should at least consider whether all types of traffic are ok to leave the node untranslated). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past we would just pass up packets with unknown protocols, and let the next layer (or the stack) deal with them.
#19753 recently added error handling for the revSNAT paths, so that we can catch errors while eg. rewriting the packet headers.
But we want to preserve the old behaviour of tolerating unknown protocol types. So return NAT_PUNT_TO_STACK from a few additional ICMP paths.