slices: Introduce slices.UniqueFunc() #25743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YutaroHayakawa
added
the
release-note/misc
|
Let me ask for your review @pippolo84 since you are the original author of the |
|
/test |
pippolo84
approved these changes
May 29, 2023
Add a new function UniqueFunc() that deduplicates given slice like Unique(), but users can pass function to extract comparable key to compare the elements. We didn't applied the optimization applied for Unique in UniqueFunc, because when we measure the performance, a simple map-based deduplication showed a good performance in terms of the deduplication speed (but has extra allocation). Unique ``` cpu: 11th Gen Intel(R) Core(TM) i7-1195G7 @ 2.90GHz BenchmarkUnique BenchmarkUnique/96 BenchmarkUnique/96-8 576111 1877 ns/op 0 B/op 0 allocs/op BenchmarkUnique/128 BenchmarkUnique/128-8 376249 3162 ns/op 0 B/op 0 allocs/op BenchmarkUnique/160 BenchmarkUnique/160-8 267973 4758 ns/op 0 B/op 0 allocs/op BenchmarkUnique/192 BenchmarkUnique/192-8 205845 5518 ns/op 3134 B/op 4 allocs/op BenchmarkUnique/256 BenchmarkUnique/256-8 165156 6981 ns/op 6177 B/op 2 allocs/op BenchmarkUnique/512 BenchmarkUnique/512-8 89644 13566 ns/op 10927 B/op 3 allocs/op BenchmarkUnique/1024 BenchmarkUnique/1024-8 46180 26177 ns/op 21819 B/op 4 allocs/op ``` UniqueFunc with the Unique-like optimization (compare elements like `key(i) == key(j)`) ``` cpu: 11th Gen Intel(R) Core(TM) i7-1195G7 @ 2.90GHz BenchmarkUniqueFunc BenchmarkUniqueFunc/96 BenchmarkUniqueFunc/96-8 109359 11018 ns/op 0 B/op 0 allocs/op BenchmarkUniqueFunc/128 BenchmarkUniqueFunc/128-8 63355 17134 ns/op 0 B/op 0 allocs/op BenchmarkUniqueFunc/160 BenchmarkUniqueFunc/160-8 42169 26700 ns/op 0 B/op 0 allocs/op BenchmarkUniqueFunc/192 BenchmarkUniqueFunc/192-8 192640 6253 ns/op 3143 B/op 4 allocs/op BenchmarkUniqueFunc/256 BenchmarkUniqueFunc/256-8 150264 7652 ns/op 6176 B/op 2 allocs/op BenchmarkUniqueFunc/512 BenchmarkUniqueFunc/512-8 79173 15185 ns/op 10927 B/op 3 allocs/op BenchmarkUniqueFunc/1024 BenchmarkUniqueFunc/1024-8 41577 29245 ns/op 21821 B/op 4 allocs/op ``` UniqueFunc with simple map-based deduplication ``` cpu: 11th Gen Intel(R) Core(TM) i7-1195G7 @ 2.90GHz BenchmarkUniqueFunc BenchmarkUniqueFunc/96 BenchmarkUniqueFunc/96-8 393656 3258 ns/op 1474 B/op 3 allocs/op BenchmarkUniqueFunc/128 BenchmarkUniqueFunc/128-8 272712 4091 ns/op 3099 B/op 2 allocs/op BenchmarkUniqueFunc/160 BenchmarkUniqueFunc/160-8 232684 5242 ns/op 3118 B/op 3 allocs/op BenchmarkUniqueFunc/192 BenchmarkUniqueFunc/192-8 191180 6159 ns/op 3132 B/op 4 allocs/op BenchmarkUniqueFunc/256 BenchmarkUniqueFunc/256-8 148922 7928 ns/op 6179 B/op 2 allocs/op BenchmarkUniqueFunc/512 BenchmarkUniqueFunc/512-8 78356 15101 ns/op 10923 B/op 3 allocs/op BenchmarkUniqueFunc/1024 BenchmarkUniqueFunc/1024-8 41091 29386 ns/op 21821 B/op 4 allocs/op ``` Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
YutaroHayakawa
force-pushed
the
yutaro/unique-func
branch
from
f055145
to
ae50feb
Compare
|
/test |
|
ConformanceK8sKind: New flake. Filed an issue: #25758. |
|
ConformanceK8sKind: New flake. Filed an issue: #25759 |
|
Now all green. Ready to merge. |
YutaroHayakawa
added
the
ready-to-merge
julianwiedmann
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is extracted from #25477 since it is an independent change.
Add a new function UniqueFunc() that deduplicates given slice like Unique(), but users can pass function to extract comparable key to compare the elements.
We didn't applied the optimization applied for Unique in UniqueFunc, because when we measure the performance, a simple map-based deduplication showed a good performance in terms of the deduplication speed (but has extra allocation).
Unique
UniqueFunc with the Unique-like optimization (compare elements like
key(i) == key(j))UniqueFunc with simple map-based deduplication